third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp - Issue 2884313002: color: Rename blink::ColorSpace to blink::InterpolationSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

Issue 2884313002: color: Rename blink::ColorSpace to blink::InterpolationSpace (Closed)

Patch Set: Incorporate review feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

index 8f5bcd6e6aeb965034cc6c6e9f6b7dc086df4f33..da0ce423614f6ba5f9f758cba409414b3d4d994a 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

@@ -306,7 +306,7 @@ sk_sp<SkImageFilter> CanvasRenderingContext2DState::GetFilterForOffscreenCanvas(

filter_effect_builder.BuildFilterEffect(operations);

if (last_effect) {

resolved_filter_ =

- SkiaImageFilterBuilder::Build(last_effect, kColorSpaceDeviceRGB);

+ SkiaImageFilterBuilder::Build(last_effect, kInterpolationSpaceSRGB);

}

return resolved_filter_;

@@ -359,7 +359,7 @@ sk_sp<SkImageFilter> CanvasRenderingContext2DState::GetFilter(

if (FilterEffect* last_effect =

filter_effect_builder.BuildFilterEffect(filter_style->Filter())) {

resolved_filter_ =

- SkiaImageFilterBuilder::Build(last_effect, kColorSpaceDeviceRGB);

+ SkiaImageFilterBuilder::Build(last_effect, kInterpolationSpaceSRGB);

if (resolved_filter_) {

context->UpdateFilterReferences(filter_style->Filter());

if (last_effect->OriginTainted())