third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp - Issue 2884313002: color: Rename blink::ColorSpace to blink::InterpolationSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp

Issue 2884313002: color: Rename blink::ColorSpace to blink::InterpolationSpace (Closed)

Patch Set: Incorporate review feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp

index c06ceea71d60bc93815b952a068a1d1fb327a752..75bb34b29bc6454eb480ad69c80fdd7a11aa9bf6 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp

@@ -180,12 +180,12 @@ sk_sp<SkImageFilter> FEComposite::CreateImageFilterWithoutValidation() {

sk_sp<SkImageFilter> FEComposite::CreateImageFilterInternal(

bool requires_pm_color_validation) {

- sk_sp<SkImageFilter> foreground(

- SkiaImageFilterBuilder::Build(InputEffect(0), OperatingColorSpace(),

- !MayProduceInvalidPreMultipliedPixels()));

- sk_sp<SkImageFilter> background(

- SkiaImageFilterBuilder::Build(InputEffect(1), OperatingColorSpace(),

- !MayProduceInvalidPreMultipliedPixels()));

+ sk_sp<SkImageFilter> foreground(SkiaImageFilterBuilder::Build(

+ InputEffect(0), OperatingInterpolationSpace(),

+ !MayProduceInvalidPreMultipliedPixels()));

+ sk_sp<SkImageFilter> background(SkiaImageFilterBuilder::Build(

+ InputEffect(1), OperatingInterpolationSpace(),

+ !MayProduceInvalidPreMultipliedPixels()));

SkImageFilter::CropRect crop_rect = GetCropRect();

if (type_ == FECOMPOSITE_OPERATOR_ARITHMETIC) {