third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp - Issue 2884313002: color: Rename blink::ColorSpace to blink::InterpolationSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

Issue 2884313002: color: Rename blink::ColorSpace to blink::InterpolationSpace (Closed)

Patch Set: Incorporate review feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp b/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

index d6ee4dad99d6838fd7ac49b26eb625aee0f97cf6..475aa3a8cf04ec0b463f7d0827e78f889ecd91e5 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

@@ -58,9 +58,9 @@ sk_sp<SkImageFilter> FELighting::CreateImageFilter() {

return CreateTransparentBlack();

SkImageFilter::CropRect rect = GetCropRect();

- Color light_color = AdaptColorToOperatingColorSpace(lighting_color_);

- sk_sp<SkImageFilter> input(

- SkiaImageFilterBuilder::Build(InputEffect(0), OperatingColorSpace()));

+ Color light_color = AdaptColorToOperatingInterpolationSpace(lighting_color_);

+ sk_sp<SkImageFilter> input(SkiaImageFilterBuilder::Build(

+ InputEffect(0), OperatingInterpolationSpace()));

switch (light_source_->GetType()) {

case LS_DISTANT: {

DistantLightSource* distant_light_source =