Shifted creation of unvalidated CanonicalCookies over to a constructor.

Shifted creation of unvalidated CanonicalCookies over to a constructor.

The existing Create() method allowed creation of arbitrary (unvalidated)
CanonicalCookies, but they could only be created from heap allocations.
This allows more flexibility in creating such cookies.

BUG=None
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2874843002
Cr-Commit-Position: refs/heads/master@{#472127}
Committed: https://chromium.googlesource.com/chromium/src/+/51010b09aee5cfb455f39cee84cbdbaf58169cde

[Randy Smith (Not in Mondays), 2017-05-10 18:13:58]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 18:16:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 18:30:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 18:30:36]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Randy Smith (Not in Mondays), 2017-05-11 00:13:40]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 00:15:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 00:28:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 00:28:27]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Randy Smith (Not in Mondays), 2017-05-11 02:36:09]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 02:37:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 04:36:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:36:20]

Dry run: This issue passed the CQ dry run.

[Randy Smith (Not in Mondays), 2017-05-11 05:51:51]

Whenever you get a chance--there are several things (including code reviews for
you :-}) that are higher priority than getting this in.

[mmenke, 2017-05-11 15:14:49]

LGTM!

[Randy Smith (Not in Mondays), 2017-05-12 18:02:08]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 18:05:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Randy Smith (Not in Mondays), 2017-05-12 18:05:39]

rdsmith@chromium.org changed reviewers:
+ alexclarke@chromium.org, ellyjones@chromium.org, jam@chromium.org,
mkwst@chromium.org, rogerta@chromium.org

[Randy Smith (Not in Mondays), 2017-05-12 18:05:39]

Same suspect as last time; PTAL?  This is a fairly mechanical change, probably
TBRable, though I'm always a bit reluctant to make that call.  

+ellyjones: ios/net

+mkwst: chrome/browser/extensions/api/cookies, content/browser/browsing_data

+jam: content/browser/net 

+rogerta: components/signin/core/browser

+alexclarke: headless

[commit-bot: I haz the power, 2017-05-12 19:22:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 19:22:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-05-12 19:52:50]

lgtm

[Elly Fong-Jones, 2017-05-12 19:53:57]

ios/net lgtm

[Mike West, 2017-05-15 07:37:49]

lgtm

[Roger Tawa OOO till Jul 10th, 2017-05-15 15:16:59]

components/signin lgtm

[alex clarke (OOO till 29th), 2017-05-16 12:42:21]

headless LGTM

[Randy Smith (Not in Mondays), 2017-05-16 14:18:41]

The CQ bit was checked by rdsmith@chromium.org

[Randy Smith (Not in Mondays), 2017-05-16 14:18:41]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2874843002/#ps60001
(title: "Merged to top of dependent CL.")

[commit-bot: I haz the power, 2017-05-16 14:19:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 16:23:22]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494944321184180,
"parent_rev": "5413280afdd44bd90e6dc90bd7a09090a9743290", "commit_rev":
"51010b09aee5cfb455f39cee84cbdbaf58169cde"}

[commit-bot: I haz the power, 2017-05-16 16:23:36]

Description was changed from

==========
Shifted creation of unvalidated CanonicalCookies over to a constructor.

The existing Create() method allowed creation of arbitrary (unvalidated)
CanonicalCookies, but they could only be created from heap allocations.
This allows more flexibility in creating such cookies.

BUG=None
R=mmenke@chromium.org
==========

to

==========
Shifted creation of unvalidated CanonicalCookies over to a constructor.

The existing Create() method allowed creation of arbitrary (unvalidated)
CanonicalCookies, but they could only be created from heap allocations.
This allows more flexibility in creating such cookies.

BUG=None
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2874843002
Cr-Commit-Position: refs/heads/master@{#472127}
Committed:
https://chromium.googlesource.com/chromium/src/+/51010b09aee5cfb455f39cee84cb...
==========

[commit-bot: I haz the power, 2017-05-16 16:23:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/51010b09aee5cfb455f39cee84cb...