Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: chrome/browser/extensions/api/cookies/cookies_unittest.cc

Issue 2874843002: Shifted creation of unvalidated CanonicalCookies over to a constructor. (Closed)
Patch Set: Merged to top of dependent CL. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cookies/cookies_unittest.cc
diff --git a/chrome/browser/extensions/api/cookies/cookies_unittest.cc b/chrome/browser/extensions/api/cookies/cookies_unittest.cc
index a68804b7ee726a905d75be85a91ab068873622de..a236be223408cad3a4306e7f1b18d8e7c9de1e8b 100644
--- a/chrome/browser/extensions/api/cookies/cookies_unittest.cc
+++ b/chrome/browser/extensions/api/cookies/cookies_unittest.cc
@@ -86,7 +86,7 @@ TEST_F(ExtensionCookiesTest, StoreIdProfileConversion) {
TEST_F(ExtensionCookiesTest, ExtensionTypeCreation) {
std::unique_ptr<net::CanonicalCookie> canonical_cookie1(
- net::CanonicalCookie::Create(
+ base::MakeUnique<net::CanonicalCookie>(
"ABC", "DEF", "www.example.com", "/", base::Time(), base::Time(),
base::Time(), false, false, net::CookieSameSite::DEFAULT_MODE,
net::COOKIE_PRIORITY_DEFAULT));
@@ -106,7 +106,7 @@ TEST_F(ExtensionCookiesTest, ExtensionTypeCreation) {
EXPECT_EQ("some cookie store", cookie1.store_id);
std::unique_ptr<net::CanonicalCookie> canonical_cookie2(
- net::CanonicalCookie::Create(
+ base::MakeUnique<net::CanonicalCookie>(
"ABC", "DEF", ".example.com", "/", base::Time(),
base::Time::FromDoubleT(10000), base::Time(), false, false,
net::CookieSameSite::STRICT_MODE, net::COOKIE_PRIORITY_DEFAULT));
@@ -129,18 +129,20 @@ TEST_F(ExtensionCookiesTest, ExtensionTypeCreation) {
}
TEST_F(ExtensionCookiesTest, GetURLFromCanonicalCookie) {
- std::unique_ptr<net::CanonicalCookie> cookie1(net::CanonicalCookie::Create(
- "ABC", "DEF", ".example.com", "/", base::Time(), base::Time(),
- base::Time(), false, false, net::CookieSameSite::DEFAULT_MODE,
- net::COOKIE_PRIORITY_DEFAULT));
+ std::unique_ptr<net::CanonicalCookie> cookie1(
+ base::MakeUnique<net::CanonicalCookie>(
+ "ABC", "DEF", ".example.com", "/", base::Time(), base::Time(),
+ base::Time(), false, false, net::CookieSameSite::DEFAULT_MODE,
+ net::COOKIE_PRIORITY_DEFAULT));
ASSERT_NE(nullptr, cookie1.get());
EXPECT_EQ("http://example.com/",
cookies_helpers::GetURLFromCanonicalCookie(*cookie1).spec());
- std::unique_ptr<net::CanonicalCookie> cookie2(net::CanonicalCookie::Create(
- "ABC", "DEF", ".helloworld.com", "/", base::Time(), base::Time(),
- base::Time(), true, false, net::CookieSameSite::DEFAULT_MODE,
- net::COOKIE_PRIORITY_DEFAULT));
+ std::unique_ptr<net::CanonicalCookie> cookie2(
+ base::MakeUnique<net::CanonicalCookie>(
+ "ABC", "DEF", ".helloworld.com", "/", base::Time(), base::Time(),
+ base::Time(), true, false, net::CookieSameSite::DEFAULT_MODE,
+ net::COOKIE_PRIORITY_DEFAULT));
ASSERT_NE(nullptr, cookie2.get());
EXPECT_EQ("https://helloworld.com/",
cookies_helpers::GetURLFromCanonicalCookie(*cookie2).spec());
@@ -172,10 +174,11 @@ TEST_F(ExtensionCookiesTest, DomainMatching) {
std::unique_ptr<GetAll::Params> params(GetAll::Params::Create(args));
cookies_helpers::MatchFilter filter(&params->details);
- std::unique_ptr<net::CanonicalCookie> cookie(net::CanonicalCookie::Create(
- "name", std::string(), tests[i].domain, "/", base::Time(), base::Time(),
- base::Time(), false, false, net::CookieSameSite::DEFAULT_MODE,
- net::COOKIE_PRIORITY_DEFAULT));
+ std::unique_ptr<net::CanonicalCookie> cookie(
+ base::MakeUnique<net::CanonicalCookie>(
+ "name", std::string(), tests[i].domain, "/", base::Time(),
+ base::Time(), base::Time(), false, false,
+ net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
ASSERT_NE(nullptr, cookie.get());
EXPECT_EQ(tests[i].matches, filter.MatchesCookie(*cookie)) << " test " << i;
}
« no previous file with comments | « chrome/browser/android/cookies/cookies_fetcher.cc ('k') | components/signin/core/browser/gaia_cookie_manager_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698