Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: components/signin/core/browser/gaia_cookie_manager_service.cc

Issue 2874843002: Shifted creation of unvalidated CanonicalCookies over to a constructor. (Closed)
Patch Set: Merged to top of dependent CL. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/gaia_cookie_manager_service.cc
diff --git a/components/signin/core/browser/gaia_cookie_manager_service.cc b/components/signin/core/browser/gaia_cookie_manager_service.cc
index 58556caf7317c32780ae6c1dea6f7e13828c392a..78b8b5deff15f713e09dfb8641ec13177e8d5682 100644
--- a/components/signin/core/browser/gaia_cookie_manager_service.cc
+++ b/components/signin/core/browser/gaia_cookie_manager_service.cc
@@ -10,6 +10,7 @@
#include "base/format_macros.h"
#include "base/json/json_reader.h"
+#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
#include "base/stl_util.h"
#include "base/strings/string_util.h"
@@ -402,10 +403,11 @@ void GaiaCookieManagerService::TriggerListAccounts(const std::string& source) {
void GaiaCookieManagerService::ForceOnCookieChangedProcessing() {
GURL google_url = GaiaUrls::GetInstance()->google_url();
- std::unique_ptr<net::CanonicalCookie> cookie(net::CanonicalCookie::Create(
- kGaiaCookieName, std::string(), "." + google_url.host(), "/",
- base::Time(), base::Time(), base::Time(), false, false,
- net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
+ std::unique_ptr<net::CanonicalCookie> cookie(
+ base::MakeUnique<net::CanonicalCookie>(
+ kGaiaCookieName, std::string(), "." + google_url.host(), "/",
+ base::Time(), base::Time(), base::Time(), false, false,
+ net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
OnCookieChanged(*cookie, net::CookieStore::ChangeCause::UNKNOWN_DELETION);
}

Powered by Google App Engine
This is Rietveld 408576698