Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: content/browser/browsing_data/browsing_data_remover_impl_unittest.cc

Issue 2874843002: Shifted creation of unvalidated CanonicalCookies over to a constructor. (Closed)
Patch Set: Merged to top of dependent CL. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include <list> 8 #include <list>
9 #include <memory> 9 #include <memory>
10 #include <set> 10 #include <set>
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 uint32_t quota_storage_remove_mask = 0; 110 uint32_t quota_storage_remove_mask = 0;
111 base::Time remove_begin; 111 base::Time remove_begin;
112 base::Time remove_end; 112 base::Time remove_end;
113 StoragePartition::OriginMatcherFunction origin_matcher; 113 StoragePartition::OriginMatcherFunction origin_matcher;
114 StoragePartition::CookieMatcherFunction cookie_matcher; 114 StoragePartition::CookieMatcherFunction cookie_matcher;
115 115
116 StoragePartitionRemovalData() {} 116 StoragePartitionRemovalData() {}
117 }; 117 };
118 118
119 net::CanonicalCookie CreateCookieWithHost(const GURL& source) { 119 net::CanonicalCookie CreateCookieWithHost(const GURL& source) {
120 std::unique_ptr<net::CanonicalCookie> cookie(net::CanonicalCookie::Create( 120 std::unique_ptr<net::CanonicalCookie> cookie(
121 "A", "1", source.host(), "/", base::Time::Now(), base::Time::Now(), 121 base::MakeUnique<net::CanonicalCookie>(
122 base::Time(), false, false, net::CookieSameSite::DEFAULT_MODE, 122 "A", "1", source.host(), "/", base::Time::Now(), base::Time::Now(),
123 net::COOKIE_PRIORITY_MEDIUM)); 123 base::Time(), false, false, net::CookieSameSite::DEFAULT_MODE,
124 net::COOKIE_PRIORITY_MEDIUM));
124 EXPECT_TRUE(cookie); 125 EXPECT_TRUE(cookie);
125 return *cookie; 126 return *cookie;
126 } 127 }
127 128
128 class TestStoragePartition : public StoragePartition { 129 class TestStoragePartition : public StoragePartition {
129 public: 130 public:
130 TestStoragePartition() {} 131 TestStoragePartition() {}
131 ~TestStoragePartition() override {} 132 ~TestStoragePartition() override {}
132 133
133 // StoragePartition implementation. 134 // StoragePartition implementation.
(...skipping 1514 matching lines...) Expand 10 before | Expand all | Expand 10 after
1648 1649
1649 // Add one more deletion and wait for it. 1650 // Add one more deletion and wait for it.
1650 BlockUntilBrowsingDataRemoved( 1651 BlockUntilBrowsingDataRemoved(
1651 base::Time(), base::Time::Max(), BrowsingDataRemover::DATA_TYPE_COOKIES, 1652 base::Time(), base::Time::Max(), BrowsingDataRemover::DATA_TYPE_COOKIES,
1652 BrowsingDataRemover::ORIGIN_TYPE_UNPROTECTED_WEB); 1653 BrowsingDataRemover::ORIGIN_TYPE_UNPROTECTED_WEB);
1653 1654
1654 EXPECT_FALSE(remover->is_removing()); 1655 EXPECT_FALSE(remover->is_removing());
1655 } 1656 }
1656 1657
1657 } // namespace content 1658 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698