Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: ios/net/cookies/cookie_store_ios.mm

Issue 2874843002: Shifted creation of unvalidated CanonicalCookies over to a constructor. (Closed)
Patch Set: Merged to top of dependent CL. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/net/cookies/cookie_cache_unittest.cc ('k') | ios/net/cookies/cookie_store_ios_test_util.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/net/cookies/cookie_store_ios.mm
diff --git a/ios/net/cookies/cookie_store_ios.mm b/ios/net/cookies/cookie_store_ios.mm
index 1856af7b8d303b7ec02a600ca0d74a6ef2546cc8..2ea0715a4cbaaa30036ee3c132e3e287d928b7eb 100644
--- a/ios/net/cookies/cookie_store_ios.mm
+++ b/ios/net/cookies/cookie_store_ios.mm
@@ -407,10 +407,10 @@ void CookieStoreIOS::SetCookieWithDetailsAsync(
// First create a CanonicalCookie, to normalize the arguments,
// particularly domain and path, and perform validation.
std::unique_ptr<net::CanonicalCookie> canonical_cookie =
- net::CanonicalCookie::Create(name, value, cookie_domain, cookie_path,
- creation_time, expiration_time,
- creation_time, secure, http_only, same_site,
- priority);
+ base::MakeUnique<net::CanonicalCookie>(
+ name, value, cookie_domain, cookie_path, creation_time,
+ expiration_time, creation_time, secure, http_only, same_site,
+ priority);
if (canonical_cookie) {
NSHTTPCookie* cookie = SystemCookieFromCanonicalCookie(*canonical_cookie);
« no previous file with comments | « ios/net/cookies/cookie_cache_unittest.cc ('k') | ios/net/cookies/cookie_store_ios_test_util.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698