Remove dangerous CanonicalCookie::Create method.

Remove dangerous CanonicalCookie::Create method.

Remove the CanonicalCookie::Create method that takes a URL and a domain,
creating host cookies if the domain is null and domain cookies if it isn't.
Usage was almost completely confined to tests.

BUG=None
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2861063003
Cr-Commit-Position: refs/heads/master@{#471378}
Committed: https://chromium.googlesource.com/chromium/src/+/b4ecb4c3b8454ef2f6535d820131dfa57e3e6118

[Randy Smith (Not in Mondays), 2017-05-05 00:35:49]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 00:36:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 00:47:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 00:47:56]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Randy Smith (Not in Mondays), 2017-05-05 02:37:56]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 02:38:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 02:46:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 02:46:44]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[mmenke, 2017-05-05 17:51:57]

Know this isn't ready for review yet, but your question made me curious

https://codereview.chromium.org/2861063003/diff/20001/content/browser/browsin...
File content/browser/browsing_data/browsing_data_remover_impl_unittest.cc
(right):

https://codereview.chromium.org/2861063003/diff/20001/content/browser/browsin...
content/browser/browsing_data/browsing_data_remover_impl_unittest.cc:121: "A",
"1", "." + source.host(), "/", base::Time::Now(), base::Time::Now(),
I think this used to be exact matches?  (i.e., no dot)

[Randy Smith (Not in Mondays), 2017-05-05 21:12:06]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[Randy Smith (Not in Mondays), 2017-05-05 21:12:58]

Thanks for the pointer!  Fixed that and all the failing try jobs.

https://codereview.chromium.org/2861063003/diff/20001/content/browser/browsin...
File content/browser/browsing_data/browsing_data_remover_impl_unittest.cc
(right):

https://codereview.chromium.org/2861063003/diff/20001/content/browser/browsin...
content/browser/browsing_data/browsing_data_remover_impl_unittest.cc:121: "A",
"1", "." + source.host(), "/", base::Time::Now(), base::Time::Now(),
On 2017/05/05 17:51:56, mmenke wrote:
> I think this used to be exact matches?  (i.e., no dot)

Yep, oops.  Doesn't change the test outcome to fix it, though :-}.

[commit-bot: I haz the power, 2017-05-05 21:13:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Randy Smith (Not in Mondays), 2017-05-05 21:13:41]

Sorry, to be clear: Not yet asking for review until the try jobs actually show
green and I go over it once and decide how persnickety to be with, e.g.,
DCHECKs.

[commit-bot: I haz the power, 2017-05-05 21:26:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 21:26:35]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mmenke, 2017-05-05 23:12:58]

On 2017/05/05 21:13:41, Randy Smith (Not in Mondays) wrote:
> Sorry, to be clear: Not yet asking for review until the try jobs actually show
> green and I go over it once and decide how persnickety to be with, e.g.,
> DCHECKs.

Awesome!  Thanks for doing this.  Going to go ahead and wait until you have
tests passing before reviewing, if you don't mind.

[Randy Smith (Not in Mondays), 2017-05-06 00:04:29]

On 2017/05/05 23:12:58, mmenke wrote:
> On 2017/05/05 21:13:41, Randy Smith (Not in Mondays) wrote:
> > Sorry, to be clear: Not yet asking for review until the try jobs actually
show
> > green and I go over it once and decide how persnickety to be with, e.g.,
> > DCHECKs.
> 
> Awesome!  Thanks for doing this.  Going to go ahead and wait until you have
> tests passing before reviewing, if you don't mind.

Can't imagine why you'd prefer that :-}.  I'll ping you when I have something
worth reviewing.

[Randy Smith (Not in Mondays), 2017-05-06 21:48:10]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-06 21:48:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 21:57:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-06 21:57:32]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Randy Smith (Not in Mondays), 2017-05-06 21:59:13]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-06 21:59:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Randy Smith (Not in Mondays), 2017-05-06 22:20:58]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-06 22:21:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 23:43:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-06 23:43:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Randy Smith (Not in Mondays), 2017-05-07 09:56:32]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-07 09:56:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-07 10:17:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-07 10:17:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Randy Smith (Not in Mondays), 2017-05-07 11:47:56]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-07 11:48:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-07 13:09:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-07 13:09:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Randy Smith (Not in Mondays), 2017-05-09 01:08:31]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 01:17:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Randy Smith (Not in Mondays), 2017-05-09 03:25:19]

I'm going to jump the gun (all bots green but one, which is still yellow)  and
say that I consider this now worth reviewing.  Matt, PTAL?

[commit-bot: I haz the power, 2017-05-09 03:29:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 03:29:58]

Dry run: This issue passed the CQ dry run.

[mmenke, 2017-05-09 16:51:09]

https://codereview.chromium.org/2861063003/diff/160001/headless/public/util/g...
File headless/public/util/generic_url_request_job_test.cc (right):

https://codereview.chromium.org/2861063003/diff/160001/headless/public/util/g...
headless/public/util/generic_url_request_job_test.cc:418: "bad_path_cookie",
"7", "example.com", "/gadgets", base::Time(),
.example.com

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/canonical_...
File net/cookies/canonical_cookie.h (right):

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/canonical_...
net/cookies/canonical_cookie.h:44: // |name| and |path| may not be empty.
I think this is a MUST and not a MAY.  :)

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/canonical_...
net/cookies/canonical_cookie.h:127: const std::string& path_string);
Does this need to be public (Or even outside a private namespace in the cc
file?)  I'm not seeing anything that uses it.

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/canonical_...
File net/cookies/canonical_cookie_unittest.cc (left):

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/canonical_...
net/cookies/canonical_cookie_unittest.cc:603:
EXPECT_TRUE(https_cookie_secure_extended.get());
Should we test these failures with CookieMonster::SetCookieWithDetails, or is
that part of the API going away as well?

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/cookie_mon...
File net/cookies/cookie_monster.cc (right):

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/cookie_mon...
net/cookies/cookie_monster.cc:1069: return false;
optional:  Maybe just merge these into one if?

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/cookie_mon...
File net/cookies/cookie_monster_store_test.cc (right):

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/cookie_mon...
net/cookies/cookie_monster_store_test.cc:133: return
CanonicalCookie::Create(pc.Name(), pc.Value(), url.host(), cookie_path,
This is a behavior change.  Should be "." + cookie_path.

https://codereview.chromium.org/2861063003/diff/160001/net/extras/sqlite/sqli...
File net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc (right):

https://codereview.chromium.org/2861063003/diff/160001/net/extras/sqlite/sqli...
net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc:80: GURL
gurl("http://www" + domain_name);
Not used?

[Randy Smith (Not in Mondays), 2017-05-09 23:52:15]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[Randy Smith (Not in Mondays), 2017-05-09 23:52:36]

Next round; PTAL?

https://codereview.chromium.org/2861063003/diff/160001/headless/public/util/g...
File headless/public/util/generic_url_request_job_test.cc (right):

https://codereview.chromium.org/2861063003/diff/160001/headless/public/util/g...
headless/public/util/generic_url_request_job_test.cc:418: "bad_path_cookie",
"7", "example.com", "/gadgets", base::Time(),
On 2017/05/09 16:51:09, mmenke wrote:
> .example.com

Done.

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/canonical_...
File net/cookies/canonical_cookie.h (right):

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/canonical_...
net/cookies/canonical_cookie.h:44: // |name| and |path| may not be empty.
On 2017/05/09 16:51:09, mmenke wrote:
> I think this is a MUST and not a MAY.  :)

Done :-}.

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/canonical_...
net/cookies/canonical_cookie.h:127: const std::string& path_string);
On 2017/05/09 16:51:09, mmenke wrote:
> Does this need to be public (Or even outside a private namespace in the cc
> file?)  I'm not seeing anything that uses it.

It's used in cookie_monster.cc.  We could look into ways to make it only visible
there and to CC, but I think something like this is going to be needed as per my
recent email to you and mkwst@, so my inclination is not to put a lot of energy
into it.

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/canonical_...
File net/cookies/canonical_cookie_unittest.cc (left):

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/canonical_...
net/cookies/canonical_cookie_unittest.cc:603:
EXPECT_TRUE(https_cookie_secure_extended.get());
On 2017/05/09 16:51:09, mmenke wrote:
> Should we test these failures with CookieMonster::SetCookieWithDetails, or is
> that part of the API going away as well?

It may be at some point in the future, but not in this CL, and I'm paranoid
enough about the future to not want to count on predicting it.  I've added an
equivalent (I believe) CookieMonster test.

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/cookie_mon...
File net/cookies/cookie_monster.cc (right):

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/cookie_mon...
net/cookies/cookie_monster.cc:1069: return false;
On 2017/05/09 16:51:09, mmenke wrote:
> optional:  Maybe just merge these into one if?

Done.

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/cookie_mon...
File net/cookies/cookie_monster_store_test.cc (right):

https://codereview.chromium.org/2861063003/diff/160001/net/cookies/cookie_mon...
net/cookies/cookie_monster_store_test.cc:133: return
CanonicalCookie::Create(pc.Name(), pc.Value(), url.host(), cookie_path,
On 2017/05/09 16:51:09, mmenke wrote:
> This is a behavior change.  Should be "." + cookie_path.

Presuming you meant "." + url.host().  Done.

https://codereview.chromium.org/2861063003/diff/160001/net/extras/sqlite/sqli...
File net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc (right):

https://codereview.chromium.org/2861063003/diff/160001/net/extras/sqlite/sqli...
net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc:80: GURL
gurl("http://www" + domain_name);
On 2017/05/09 16:51:09, mmenke wrote:
> Not used?

Done.

[commit-bot: I haz the power, 2017-05-09 23:53:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 00:27:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 00:27:34]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[mmenke, 2017-05-10 15:51:55]

Just one comment, otherwise, looks good.

https://codereview.chromium.org/2861063003/diff/180001/net/cookies/cookie_mon...
File net/cookies/cookie_monster_unittest.cc (right):

https://codereview.chromium.org/2861063003/diff/180001/net/cookies/cookie_mon...
net/cookies/cookie_monster_unittest.cc:3224: TEST_F(CookieMonsterTest,
SetCookieWithDetailsSecureEnforcement) {
Should this be in the shared test (cookie_store_unittest.h), so it's run on iOS,
too, since the same logic was added there?

[Randy Smith (Not in Mondays), 2017-05-10 17:38:49]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 17:40:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Randy Smith (Not in Mondays), 2017-05-10 20:31:52]

PTA(nother)L?

https://codereview.chromium.org/2861063003/diff/180001/net/cookies/cookie_mon...
File net/cookies/cookie_monster_unittest.cc (right):

https://codereview.chromium.org/2861063003/diff/180001/net/cookies/cookie_mon...
net/cookies/cookie_monster_unittest.cc:3224: TEST_F(CookieMonsterTest,
SetCookieWithDetailsSecureEnforcement) {
On 2017/05/10 15:51:54, mmenke wrote:
> Should this be in the shared test (cookie_store_unittest.h), so it's run on
iOS,
> too, since the same logic was added there?

Done.

[mmenke, 2017-05-10 20:33:19]

LGTM

[commit-bot: I haz the power, 2017-05-10 21:54:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 21:54:13]

Dry run: This issue passed the CQ dry run.

[commit-bot: I haz the power, 2017-05-10 21:55:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 21:55:17]

Dry run: This issue passed the CQ dry run.

[Randy Smith (Not in Mondays), 2017-05-10 21:55:27]

The CQ bit was checked by rdsmith@chromium.org

[commit-bot: I haz the power, 2017-05-10 21:57:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 22:17:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 22:17:53]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Randy Smith (Not in Mondays), 2017-05-10 23:39:08]

rdsmith@chromium.org changed reviewers:
+ alexclarke@chromium.org, droger@chromium.org, jam@chromium.org,
mkwst@chromium.org, msarda@chromium.org

[Randy Smith (Not in Mondays), 2017-05-10 23:39:09]

+droger: ios/net

+mkwst: chrome/browser/extensions/api/cookies, content/browser/browsing_data

+jam: content/browser/net (Not sure why this isn't under net/OWNERS, but it's
not)

+msarda: components/signin/core/browser

+alexclarke: headless

[alex clarke (OOO till 29th), 2017-05-11 07:12:35]

headless/ LGTM

[Mike West, 2017-05-11 07:42:23]

//chrome/browser/extensions/api/cookies and //content/browser/browsing_data
LGTM.

[jam, 2017-05-11 15:00:11]

lgtm

[Randy Smith (Not in Mondays), 2017-05-11 16:26:36]

rdsmith@chromium.org changed reviewers:
+ ellyjones@chromium.org, rogerta@chromium.org
- droger@chromium.org, msarda@chromium.org

[Randy Smith (Not in Mondays), 2017-05-11 16:26:37]

Elly, would you be willing to look at ios/net?

Roger, would you be willing to look at components/signin/core/browser?

I think I've hit holidays for David and Mihai.

[Elly Fong-Jones, 2017-05-11 17:24:35]

ios/net lgtm

https://codereview.chromium.org/2861063003/diff/200001/ios/net/cookies/cookie...
File ios/net/cookies/cookie_store_ios.mm (right):

https://codereview.chromium.org/2861063003/diff/200001/ios/net/cookies/cookie...
ios/net/cookies/cookie_store_ios.mm:412: // TODO(rdsmith): Check with ios
reviewer about whether to use
I would use creation_time, which is what the old ::Create() method would have
done.

It's possible that last_access_time is more correct, but since this method is
backed by the system cookie store which does not have any known notion of a
separate last access time, I doubt that it matters. Even the creation time is
actually spelunked out of the NSHTTPCookie object in a strange way:
https://cs.chromium.org/chromium/src/ios/net/cookies/cookie_creation_time_man...

[Roger Tawa OOO till Jul 10th, 2017-05-12 16:47:37]

components/signin lgtm

[Randy Smith (Not in Mondays), 2017-05-12 17:02:02]

Thanks, all!

https://codereview.chromium.org/2861063003/diff/200001/ios/net/cookies/cookie...
File ios/net/cookies/cookie_store_ios.mm (right):

https://codereview.chromium.org/2861063003/diff/200001/ios/net/cookies/cookie...
ios/net/cookies/cookie_store_ios.mm:412: // TODO(rdsmith): Check with ios
reviewer about whether to use
On 2017/05/11 17:24:35, Elly Fong-Jones wrote:
> I would use creation_time, which is what the old ::Create() method would have
> done.
> 
> It's possible that last_access_time is more correct, but since this method is
> backed by the system cookie store which does not have any known notion of a
> separate last access time, I doubt that it matters. Even the creation time is
> actually spelunked out of the NSHTTPCookie object in a strange way:
>
https://cs.chromium.org/chromium/src/ios/net/cookies/cookie_creation_time_man...

Done.

[Randy Smith (Not in Mondays), 2017-05-12 17:02:08]

The CQ bit was checked by rdsmith@chromium.org

[Randy Smith (Not in Mondays), 2017-05-12 17:02:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
rogerta@chromium.org, jam@chromium.org, ellyjones@chromium.org,
mkwst@chromium.org, mmenke@chromium.org, alexclarke@chromium.org
Link to the patchset: https://codereview.chromium.org/2861063003/#ps220001
(title: "Use creation_time for last_access_time as per Elly's suggestion.")

[commit-bot: I haz the power, 2017-05-12 17:03:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 18:39:07]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1494608528863710,
"parent_rev": "0ee47102dc41a4336c77ab1489ff5a2601117b86", "commit_rev":
"b4ecb4c3b8454ef2f6535d820131dfa57e3e6118"}

[commit-bot: I haz the power, 2017-05-12 18:39:20]

Description was changed from

==========
Remove dangerous CanonicalCookie::Create method.

Remove the CanonicalCookie::Create method that takes a URL and a domain,
creating host cookies if the domain is null and domain cookies if it isn't.
Usage was almost completely confined to tests.

BUG=None
R=mmenke@chromium.org
==========

to

==========
Remove dangerous CanonicalCookie::Create method.

Remove the CanonicalCookie::Create method that takes a URL and a domain,
creating host cookies if the domain is null and domain cookies if it isn't.
Usage was almost completely confined to tests.

BUG=None
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2861063003
Cr-Commit-Position: refs/heads/master@{#471378}
Committed:
https://chromium.googlesource.com/chromium/src/+/b4ecb4c3b8454ef2f6535d820131...
==========

[commit-bot: I haz the power, 2017-05-12 18:39:21]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/b4ecb4c3b8454ef2f6535d820131...