ios/net/cookies/system_cookie_util.mm - Issue 2874843002: Shifted creation of unvalidated CanonicalCookies over to a constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/net/cookies/system_cookie_util.mm

Issue 2874843002: Shifted creation of unvalidated CanonicalCookies over to a constructor. (Closed)

Patch Set: Merged to top of dependent CL. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/net/cookies/system_cookie_util.mm

diff --git a/ios/net/cookies/system_cookie_util.mm b/ios/net/cookies/system_cookie_util.mm

index b4e30752c4c0ecbdf087b8fd30f6c65861ed26e8..945bbdb5aa02a5cb5f2af41f961a05cf7d073a07 100644

--- a/ios/net/cookies/system_cookie_util.mm

+++ b/ios/net/cookies/system_cookie_util.mm

@@ -70,7 +70,7 @@ void ReportUMACookieLoss(CookieLossType loss, CookieEvent event) {

net::CanonicalCookie CanonicalCookieFromSystemCookie(

NSHTTPCookie* cookie,

const base::Time& ceation_time) {

- return *net::CanonicalCookie::Create(

+ return net::CanonicalCookie(

base::SysNSStringToUTF8([cookie name]),

base::SysNSStringToUTF8([cookie value]),

base::SysNSStringToUTF8([cookie domain]),