Move components/display_compositor to components/viz/display_compositor

Move components/display_compositor to components/viz/display_compositor

BUG=719929
Review-Url: https://codereview.chromium.org/2873243002
Cr-Commit-Position: refs/heads/master@{#472519}
Committed: https://chromium.googlesource.com/chromium/src/+/e334e566ba0d6980a21b8ffa86f0435648c7a68f

[xing.xu, 2017-05-10 02:51:22]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 02:52:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2017-05-10 02:54:18]

Description was changed from

==========
Move components/display_compositor to components/viz/display_compositor

BUG=719929
==========

to

==========
Move components/display_compositor to components/viz/display_compositor

BUG=719929
==========

[xing.xu, 2017-05-10 02:54:18]

xing.xu@intel.com changed reviewers:
+ boliu@chromium.org, fsamuel@chromium.org, jbauman@chromium.org,
rjkroege@chromium.org, staraz@chromium.org

[xing.xu, 2017-05-10 02:55:13]

PTAL:
    rjkroege@chromium.org is commented as:
      For touch/gesture specific changes (at content/browser/renderer_host)
    jbauman@chromium.org is commented as:
      DelegatedFrame* (at content/browser/renderer_host/*delegated_frame*)
    boliu@chromium.org is commented as:
      For Android (at content/browser)

[commit-bot: I haz the power, 2017-05-10 03:08:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:08:47]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[xing.xu, 2017-05-10 05:33:28]

Patchset #3 (id:40001) has been deleted

[xing.xu, 2017-05-10 05:33:43]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 05:34:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 05:47:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 05:47:33]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xing.xu, 2017-05-10 07:57:44]

Patchset #3 (id:60001) has been deleted

[xing.xu, 2017-05-10 07:59:08]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 07:59:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-05-10 09:08:29]

lgtm

[commit-bot: I haz the power, 2017-05-10 10:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 10:42:24]

Dry run: This issue passed the CQ dry run.

[Alex Z., 2017-05-10 13:33:20]

Thanks for working on this!
lgtm

[boliu, 2017-05-10 17:36:04]

lgtm w/ nit

https://codereview.chromium.org/2873243002/diff/50113/content/browser/composi...
File content/browser/compositor/browser_compositor_output_surface.h (right):

https://codereview.chromium.org/2873243002/diff/50113/content/browser/composi...
content/browser/compositor/browser_compositor_output_surface.h:18: namespace viz
{
nit: there's an general attempt at keeping these forward declarations in
alphabetical order, please go through the CL and update these where appropriate

[xing.xu, 2017-05-11 00:27:17]

https://codereview.chromium.org/2873243002/diff/50113/content/browser/composi...
File content/browser/compositor/browser_compositor_output_surface.h (right):

https://codereview.chromium.org/2873243002/diff/50113/content/browser/composi...
content/browser/compositor/browser_compositor_output_surface.h:18: namespace viz
{
On 2017/05/10 17:36:03, boliu wrote:
> nit: there's an general attempt at keeping these forward declarations in
> alphabetical order, please go through the CL and update these where
appropriate

OK, will followup.

[xing.xu, 2017-05-11 00:30:28]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-05-11 00:31:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 00:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 00:49:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xing.xu, 2017-05-11 02:46:06]

PTAL, jbauman@ for components/display_compositor/

[xing.xu, 2017-05-11 21:54:45]

xing.xu@intel.com changed reviewers:
+ danakj@chromium.org

[xing.xu, 2017-05-11 21:55:15]

PTAL, add danakj@ for components/display_compositor/

[jbauman, 2017-05-11 21:59:51]

lgtm

[xing.xu, 2017-05-11 23:19:31]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-05-11 23:20:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 23:50:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 23:50:05]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[xing.xu, 2017-05-11 23:58:09]

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    components/BUILD.gn
    components/display_compositor/BUILD.gn
    components/display_compositor/DEPS
    components/display_compositor/OWNERS
    components/display_compositor/buffer_queue.cc
    components/display_compositor/buffer_queue.h
    components/display_compositor/buffer_queue_unittest.cc
    components/display_compositor/compositor_overlay_candidate_validator.h
   
components/display_compositor/compositor_overlay_candidate_validator_android.cc
   
components/display_compositor/compositor_overlay_candidate_validator_android.h
    components/display_compositor/compositor_overlay_candidate_validator_mac.h
    components/display_compositor/compositor_overlay_candidate_validator_mac.mm
   
components/display_compositor/compositor_overlay_candidate_validator_ozone.cc
    components/display_compositor/compositor_overlay_candidate_validator_ozone.h
    components/display_compositor/compositor_overlay_candidate_validator_win.cc
    components/display_compositor/compositor_overlay_candidate_validator_win.h
    components/display_compositor/display_compositor_export.h
    components/display_compositor/display_compositor_test_suite.cc
    components/display_compositor/display_compositor_test_suite.h
    components/display_compositor/gl_helper.cc
    components/display_compositor/gl_helper.h
    components/display_compositor/gl_helper_benchmark.cc
    components/display_compositor/gl_helper_readback_support.cc
    components/display_compositor/gl_helper_readback_support.h
    components/display_compositor/gl_helper_scaling.cc
    components/display_compositor/gl_helper_scaling.h
    components/display_compositor/gl_helper_unittest.cc
    components/display_compositor/host_shared_bitmap_manager.cc
    components/display_compositor/host_shared_bitmap_manager.h
    components/display_compositor/host_shared_bitmap_manager_unittest.cc
    components/display_compositor/run_all_unittests.cc
    components/display_compositor/yuv_readback_unittest.cc
You need LGTM from owners of depends-on paths in DEPS that were modified in this
CL:
    '+cc/base',
    '+cc/ipc',
    '+cc/output',
    '+cc/resources',
    '+cc/test',
    '+gpu/ipc/common',
    '+media/base',
    '+mojo/public/cpp/bindings',
    '+mojo/public/cpp/system',
    '+third_party/khronos/GLES2',
    '+third_party/skia',
    '+ui/display',
    '+ui/gfx',
    '+ui/ozone/public',
Suggested missing target path OWNERS:
    palmer@chromium.org
    sky@chromium.org

[xing.xu, 2017-05-11 23:59:18]

xing.xu@intel.com changed reviewers:
+ palmer@chromium.org, sky@chromium.org
- danakj@chromium.org

[Fady Samuel, 2017-05-13 10:37:25]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org

[Fady Samuel, 2017-05-13 10:37:27]

+piman@ for content/ changes

[palmer, 2017-05-15 18:24:57]

RS LGTM

[piman, 2017-05-15 19:15:12]

rs lgtm

[Fady Samuel, 2017-05-15 19:16:28]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-05-15 19:17:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 19:23:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 19:23:42]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[xing.xu, 2017-05-16 02:28:37]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 02:29:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 04:35:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 04:35:43]

Dry run: This issue passed the CQ dry run.

[xing.xu, 2017-05-16 05:01:48]

The CQ bit was checked by xing.xu@intel.com

[xing.xu, 2017-05-16 05:01:49]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org,
piman@chromium.org, staraz@chromium.org, jbauman@chromium.org,
palmer@chromium.org, fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2873243002/#ps90001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-16 05:02:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 05:14:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 05:14:53]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xing.xu, 2017-05-16 05:45:52]

Hi, this requires lgtm from sky@

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    components/BUILD.gn
    components/display_compositor/BUILD.gn
    components/display_compositor/DEPS
    components/display_compositor/OWNERS
    components/display_compositor/buffer_queue.cc
    components/display_compositor/buffer_queue.h
    components/display_compositor/buffer_queue_unittest.cc
    components/display_compositor/compositor_overlay_candidate_validator.h
   
components/display_compositor/compositor_overlay_candidate_validator_android.cc
   
components/display_compositor/compositor_overlay_candidate_validator_android.h
    components/display_compositor/compositor_overlay_candidate_validator_mac.h
    components/display_compositor/compositor_overlay_candidate_validator_mac.mm
   
components/display_compositor/compositor_overlay_candidate_validator_ozone.cc
    components/display_compositor/compositor_overlay_candidate_validator_ozone.h
    components/display_compositor/compositor_overlay_candidate_validator_win.cc
    components/display_compositor/compositor_overlay_candidate_validator_win.h
    components/display_compositor/display_compositor_export.h
    components/display_compositor/display_compositor_test_suite.cc
    components/display_compositor/display_compositor_test_suite.h
    components/display_compositor/gl_helper.cc
    components/display_compositor/gl_helper.h
    components/display_compositor/gl_helper_benchmark.cc
    components/display_compositor/gl_helper_readback_support.cc
    components/display_compositor/gl_helper_readback_support.h
    components/display_compositor/gl_helper_scaling.cc
    components/display_compositor/gl_helper_scaling.h
    components/display_compositor/gl_helper_unittest.cc
    components/display_compositor/host_shared_bitmap_manager.cc
    components/display_compositor/host_shared_bitmap_manager.h
    components/display_compositor/host_shared_bitmap_manager_unittest.cc
    components/display_compositor/run_all_unittests.cc
    components/display_compositor/yuv_readback_unittest.cc
You need LGTM from owners of depends-on paths in DEPS that were modified in this
CL:
    '+media/base',
    '+mojo/public/cpp/bindings',
    '+mojo/public/cpp/system',
    '+third_party/skia',
    '+ui/display',
    '+ui/gfx',
    '+ui/ozone/public',
Suggested missing target path OWNERS:
    sky@chromium.org

[sky, 2017-05-17 15:30:58]

I think you just need me to sign off the change to
components/display_compositor/DEPS, which is just a move. LGTM

[Fady Samuel, 2017-05-17 16:14:53]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-05-17 16:15:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 19:08:15]

CQ is committing da patch.

Bot data: {"patchset_id": 90001, "attempt_start_ts": 1495037693255840,
"parent_rev": "ed6bd0bf8407291abdb23de3b194e05e65b37089", "commit_rev":
"e334e566ba0d6980a21b8ffa86f0435648c7a68f"}

[commit-bot: I haz the power, 2017-05-17 19:08:28]

Description was changed from

==========
Move components/display_compositor to components/viz/display_compositor

BUG=719929
==========

to

==========
Move components/display_compositor to components/viz/display_compositor

BUG=719929

Review-Url: https://codereview.chromium.org/2873243002
Cr-Commit-Position: refs/heads/master@{#472519}
Committed:
https://chromium.googlesource.com/chromium/src/+/e334e566ba0d6980a21b8ffa86f0...
==========

[commit-bot: I haz the power, 2017-05-17 19:08:32]

Committed patchset #4 (id:90001) as
https://chromium.googlesource.com/chromium/src/+/e334e566ba0d6980a21b8ffa86f0...