Change from ClientRect to DOMRect.

Change from ClientRect to DOMRect.

ClientRect has since been replaced by DOMRect in CSSOM View Module and Geometry Interfaces Module.

BUG=719246

[Byoungkwon Ko, 2017-05-08 17:00:11]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 17:00:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 17:11:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 17:11:19]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[zino, 2017-05-09 09:35:18]

jinho.bang@samsung.com changed reviewers:
+ jinho.bang@samsung.com

[zino, 2017-05-09 09:35:19]

I think you have to replace the ClientRect with DOMRect at all places.

[Byoungkwon Ko, 2017-05-09 14:54:53]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 14:55:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Byoungkwon Ko, 2017-05-09 15:20:11]

gogag2@gmail.com changed reviewers:
+ foolip@chromium.org

[Byoungkwon Ko, 2017-05-09 15:20:12]

@PTAL

[foolip, 2017-05-09 15:29:08]

foolip@chromium.org changed reviewers:
+ fserb@chromium.org

[foolip, 2017-05-09 15:29:09]

It's better if fserb@ does this review since crbug.com/388780 is assigned to
him. As I've said elsewhere, it's important that the aliasing changes (this and
WebKitCSSMatrix) happen together with the shipping of DOM* and are reverted
together if there's a problem. If separate CLs isn't too difficult to handle,
that's fine of course.

[foolip, 2017-05-09 15:29:42]

On 2017/05/09 15:29:09, foolip wrote:
> It's better if fserb@ does this review since crbug.com/388780 is assigned to
> him. As I've said elsewhere, it's important that the aliasing changes (this
and
> WebKitCSSMatrix) happen together with the shipping of DOM* and are reverted
> together if there's a problem. If separate CLs isn't too difficult to handle,
> that's fine of course.

So, for aliasing ClientRect to DOMRect, I'd expect ClientRect.* to be deleted
entirely, which isn't what this CL does.

[Byoungkwon Ko, 2017-05-09 15:37:35]

On 2017/05/09 15:29:42, foolip wrote:
> On 2017/05/09 15:29:09, foolip wrote:
> > It's better if fserb@ does this review since crbug.com/388780 is assigned to
> > him. As I've said elsewhere, it's important that the aliasing changes (this
> and
> > WebKitCSSMatrix) happen together with the shipping of DOM* and are reverted
> > together if there's a problem. If separate CLs isn't too difficult to
handle,
> > that's fine of course.
> 
> So, for aliasing ClientRect to DOMRect, I'd expect ClientRect.* to be deleted
> entirely, which isn't what this CL does.

Sure, I will delete ClientRect.* entirely.
Plz check below link.

https://codereview.chromium.org/2870513002/

Thanks for your review.

[commit-bot: I haz the power, 2017-05-09 16:09:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 16:09:30]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[fserb, 2017-05-10 17:43:59]

lgtm

I'm ok with this going before the remove CL.

[fserb, 2017-05-12 20:35:44]

The CQ bit was checked by fserb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 20:36:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 21:14:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 21:14:44]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fserb, 2017-05-15 14:56:36]

friendly ping on this.
Let me know if you'd rather me to patch your change and take over, this is the
biggest blocker for Geometry now.

[zino, 2017-05-15 18:50:02]

On 2017/05/15 14:56:36, fserb wrote:
> friendly ping on this.
> Let me know if you'd rather me to patch your change and take over, this is the
> biggest blocker for Geometry now.

I don't think this is biggest blocker for Geometry now..
According to the Simon's comment in the crbug issue, because the DOMRect is not
alias of ClientRect in spec side yet.
I'm not sure but we might need more discussion for this issue for compatibility.
IMHO, DOMMatrix is blocking many other features(e.g. Canvas APIs). So, we can
enable DOMMatrix first. WDYT? (ping foolip@?)

[fserb, 2017-05-15 19:25:39]

On 2017/05/15 at 18:50:02, jinho.bang wrote:
> On 2017/05/15 14:56:36, fserb wrote:
> > friendly ping on this.
> > Let me know if you'd rather me to patch your change and take over, this is
the
> > biggest blocker for Geometry now.
> 
> I don't think this is biggest blocker for Geometry now..
> According to the Simon's comment in the crbug issue, because the DOMRect is
not alias of ClientRect in spec side yet.
> I'm not sure but we might need more discussion for this issue for
compatibility.
> IMHO, DOMMatrix is blocking many other features(e.g. Canvas APIs). So, we can
enable DOMMatrix first. WDYT? (ping foolip@?)

From the original list of blockers for Geometry launch on Chrome, the remaining
ones are: ClientRect (this change) and WebKitCSSMatrix (2709765004).
I think we shouldn't split the release, I'd rather get over with two changes. 
If this one is still under consideration, I'll drop it as a blocker. But we
still need to address WebKitCSSMatrix.

[foolip, 2017-05-16 12:09:45]

As mentioned in https://bugs.chromium.org/p/chromium/issues/detail?id=719246#c7
I think we should try to just rename ClientRect* to DOMRect*, i.e. delete
ClientRect.idl and ClientRectList.idl.

[Byoungkwon Ko, 2017-06-09 22:31:30]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 22:31:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 22:34:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 22:34:50]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Byoungkwon Ko, 2017-06-09 22:46:33]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 22:46:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 22:49:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 22:49:47]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Byoungkwon Ko, 2017-06-09 23:08:06]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 23:08:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 23:11:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 23:11:50]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Byoungkwon Ko, 2017-06-09 23:16:53]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 23:17:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 23:19:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 23:19:59]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Byoungkwon Ko, 2017-06-12 23:05:46]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 23:06:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 23:09:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 23:09:51]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Byoungkwon Ko, 2017-06-14 20:49:49]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 20:50:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 20:53:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 20:53:03]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Byoungkwon Ko, 2017-06-18 13:26:54]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-18 13:27:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-18 14:09:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-18 14:09:22]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)