Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp

Issue 2869803003: Change from ClientRect to DOMRect.
Patch Set: Change from ClientRect to DOMRect. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2015 Google Inc. All rights reserved. 2 * Copyright (C) 2015 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 11 matching lines...) Expand all
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 #include "core/frame/BrowserControls.h" 30 #include "core/frame/BrowserControls.h"
31 31
32 #include "core/dom/ClientRect.h"
33 #include "core/frame/FrameTestHelpers.h" 32 #include "core/frame/FrameTestHelpers.h"
34 #include "core/frame/LocalFrame.h" 33 #include "core/frame/LocalFrame.h"
35 #include "core/frame/LocalFrameView.h" 34 #include "core/frame/LocalFrameView.h"
36 #include "core/frame/VisualViewport.h" 35 #include "core/frame/VisualViewport.h"
37 #include "core/frame/WebLocalFrameBase.h" 36 #include "core/frame/WebLocalFrameBase.h"
37 #include "core/geometry/DOMRect.h"
38 #include "core/page/Page.h" 38 #include "core/page/Page.h"
39 #include "platform/testing/URLTestHelpers.h" 39 #include "platform/testing/URLTestHelpers.h"
40 #include "platform/testing/UnitTestHelpers.h" 40 #include "platform/testing/UnitTestHelpers.h"
41 #include "public/platform/Platform.h" 41 #include "public/platform/Platform.h"
42 #include "public/platform/WebCoalescedInputEvent.h" 42 #include "public/platform/WebCoalescedInputEvent.h"
43 #include "public/platform/WebURLLoaderMockFactory.h" 43 #include "public/platform/WebURLLoaderMockFactory.h"
44 #include "public/web/WebElement.h" 44 #include "public/web/WebElement.h"
45 #include "public/web/WebSettings.h" 45 #include "public/web/WebSettings.h"
46 #include "testing/gmock/include/gmock/gmock.h" 46 #include "testing/gmock/include/gmock/gmock.h"
47 #include "testing/gtest/include/gtest/gtest.h" 47 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 1023 matching lines...) Expand 10 before | Expand all | Expand 10 after
1071 1071
1072 // Make sure we're not adding the browser controls height to the vh units as 1072 // Make sure we're not adding the browser controls height to the vh units as
1073 // when they're locked to hidden, the ICB fills the entire viewport already. 1073 // when they're locked to hidden, the ICB fills the entire viewport already.
1074 EXPECT_FLOAT_EQ(200.f, abs_pos->getBoundingClientRect()->height()); 1074 EXPECT_FLOAT_EQ(200.f, abs_pos->getBoundingClientRect()->height());
1075 EXPECT_FLOAT_EQ(200.f, fixed_pos->getBoundingClientRect()->height()); 1075 EXPECT_FLOAT_EQ(200.f, fixed_pos->getBoundingClientRect()->height());
1076 EXPECT_EQ(400, GetFrame()->View()->ViewportSizeForViewportUnits().Height()); 1076 EXPECT_EQ(400, GetFrame()->View()->ViewportSizeForViewportUnits().Height());
1077 } 1077 }
1078 } 1078 }
1079 1079
1080 } // namespace blink 1080 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698