third_party/WebKit/Source/web/tests/DocumentLoadingRenderingTest.cpp - Issue 2869803003: Change from ClientRect to DOMRect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/DocumentLoadingRenderingTest.cpp

Issue 2869803003: Change from ClientRect to DOMRect.

Patch Set: Change from ClientRect to DOMRect. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp ('k') | third_party/WebKit/Source/web/tests/RootScrollerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/DocumentLoadingRenderingTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/DocumentLoadingRenderingTest.cpp b/third_party/WebKit/Source/web/tests/DocumentLoadingRenderingTest.cpp

index 1f808b1a0cdb9d5ac37abe64348137a04842b5da..5d6e256ca5a3d3ebcba7218d3495417f5a4c99f9 100644

--- a/third_party/WebKit/Source/web/tests/DocumentLoadingRenderingTest.cpp

+++ b/third_party/WebKit/Source/web/tests/DocumentLoadingRenderingTest.cpp

@@ -2,9 +2,9 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "core/dom/ClientRect.h"

#include "core/dom/Document.h"

#include "core/dom/FrameRequestCallback.h"

+#include "core/geometry/DOMRect.h"

#include "core/html/HTMLIFrameElement.h"

#include "core/layout/api/LayoutViewItem.h"

#include "core/paint/PaintLayer.h"

@@ -411,7 +411,7 @@ TEST_F(DocumentLoadingRenderingTest,

// If ignoringPendingStylesheets==true, element should get non-empty rect.

Element* element = GetDocument().getElementById("test");

- ClientRect* rect = element->getBoundingClientRect();

+ DOMRect* rect = element->getBoundingClientRect();

EXPECT_TRUE(rect->width() > 0.f);

EXPECT_TRUE(rect->height() > 0.f);