Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: third_party/WebKit/Source/web/tests/RootScrollerTest.cpp

Issue 2869803003: Change from ClientRect to DOMRect.
Patch Set: Change from ClientRect to DOMRect. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp b/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
index 064001906379f06229ef2cda93a3cb6398464864..56c1007ae4834d397960ddc996efe47390822488 100644
--- a/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
+++ b/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
@@ -3,7 +3,6 @@
// found in the LICENSE file.
#include "bindings/core/v8/NodeOrString.h"
-#include "core/dom/ClientRect.h"
#include "core/exported/WebRemoteFrameImpl.h"
#include "core/frame/BrowserControls.h"
#include "core/frame/FrameTestHelpers.h"
@@ -11,6 +10,7 @@
#include "core/frame/RootFrameViewport.h"
#include "core/frame/VisualViewport.h"
#include "core/frame/WebLocalFrameBase.h"
+#include "core/geometry/DOMRect.h"
#include "core/html/HTMLFrameOwnerElement.h"
#include "core/layout/LayoutBox.h"
#include "core/layout/api/LayoutViewItem.h"
@@ -955,7 +955,7 @@ TEST_F(RootScrollerTest, RotationAnchoring) {
MainFrameView()->UpdateAllLifecyclePhases();
// The visual viewport should remain fully filled by the target.
- ClientRect* rect = target->getBoundingClientRect();
+ DOMRect* rect = target->getBoundingClientRect();
EXPECT_EQ(rect->left(), GetVisualViewport().GetScrollOffset().Width());
EXPECT_EQ(rect->top(), GetVisualViewport().GetScrollOffset().Height());
}

Powered by Google App Engine
This is Rietveld 408576698