Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp

Issue 2869803003: Change from ClientRect to DOMRect.
Patch Set: Change from ClientRect to DOMRect. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp b/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
index 7c16eb500fa954aa1ba07ad8f63bc08add64121c..57919818d04d77f5822251cb9d02dccfc6f59a76 100644
--- a/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
@@ -32,10 +32,10 @@
#include "bindings/core/v8/ExceptionMessages.h"
#include "bindings/core/v8/ExceptionState.h"
-#include "core/dom/ClientRect.h"
#include "core/dom/DOMTokenList.h"
#include "core/dom/ElementTraversal.h"
#include "core/dom/ExceptionCode.h"
+#include "core/geometry/DOMRect.h"
#include "core/html/HTMLDivElement.h"
#include "core/html/track/vtt/VTTParser.h"
#include "core/html/track/vtt/VTTScanner.h"
@@ -320,12 +320,13 @@ void VTTRegion::DisplayLastVTTCueBox() {
if (IsScrollingRegion())
cue_container_->classList().Add(TextTrackCueContainerScrollingClass());
- float region_bottom = region_display_tree_->getBoundingClientRect()->bottom();
+ double region_bottom =
+ region_display_tree_->getBoundingClientRect()->bottom();
// Find first cue that is not entirely displayed and scroll it upwards.
for (Element& child : ElementTraversal::ChildrenOf(*cue_container_)) {
- ClientRect* client_rect = child.getBoundingClientRect();
- float child_bottom = client_rect->bottom();
+ DOMRect* client_rect = child.getBoundingClientRect();
+ double child_bottom = client_rect->bottom();
if (region_bottom >= child_bottom)
continue;

Powered by Google App Engine
This is Rietveld 408576698