third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp - Issue 2869803003: Change from ClientRect to DOMRect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp

Issue 2869803003: Change from ClientRect to DOMRect.

Patch Set: Change from ClientRect to DOMRect. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp ('k') | third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp

diff --git a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp

index fedd97fffb66a4ec20a2ae9c9a98cce694400e26..b986b29e2e6d261ac27ccbfa152e21ac72f23bfb 100644

--- a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp

+++ b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp

@@ -5,8 +5,8 @@

#include "modules/media_controls/elements/MediaControlCastButtonElement.h"

#include "core/InputTypeNames.h"

-#include "core/dom/ClientRect.h"

#include "core/events/Event.h"

+#include "core/geometry/DOMRect.h"

#include "core/html/HTMLMediaElement.h"

#include "modules/media_controls/MediaControlsImpl.h"

#include "modules/media_controls/elements/MediaControlElementsHelper.h"

@@ -20,7 +20,7 @@ namespace blink {

namespace {

Element* ElementFromCenter(Element& element) {

- ClientRect* client_rect = element.getBoundingClientRect();

+ DOMRect* client_rect = element.getBoundingClientRect();

int center_x =

static_cast<int>((client_rect->left() + client_rect->right()) / 2);

int center_y =