Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp

Issue 2869803003: Change from ClientRect to DOMRect.
Patch Set: Change from ClientRect to DOMRect. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp b/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
index 8dd1dfdc4d45b44d0309d292c7c63fafaf706268..981b9fca98fe383282aac60130d742f399069639 100644
--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
@@ -8,12 +8,12 @@
#include <memory>
#include "core/HTMLNames.h"
#include "core/css/StylePropertySet.h"
-#include "core/dom/ClientRect.h"
#include "core/dom/Document.h"
#include "core/dom/ElementTraversal.h"
#include "core/dom/StyleEngine.h"
#include "core/events/Event.h"
#include "core/frame/Settings.h"
+#include "core/geometry/DOMRect.h"
#include "core/html/HTMLElement.h"
#include "core/html/HTMLVideoElement.h"
#include "core/html/shadow/MediaControlElementTypes.h"
@@ -668,7 +668,7 @@ TEST_F(MediaControlsImplTest, TimelineMetricsClick) {
testing::RunPendingTasks();
ASSERT_TRUE(IsElementVisible(*TimelineElement()));
- ClientRect* timelineRect = TimelineElement()->getBoundingClientRect();
+ DOMRect* timelineRect = TimelineElement()->getBoundingClientRect();
ASSERT_LT(0, timelineRect->width());
EXPECT_EQ(0, MediaControls().MediaElement().currentTime());
@@ -701,7 +701,7 @@ TEST_F(MediaControlsImplTest, TimelineMetricsDragFromCurrentPosition) {
testing::RunPendingTasks();
ASSERT_TRUE(IsElementVisible(*TimelineElement()));
- ClientRect* timeline_rect = TimelineElement()->getBoundingClientRect();
+ DOMRect* timeline_rect = TimelineElement()->getBoundingClientRect();
ASSERT_LT(0, timeline_rect->width());
EXPECT_EQ(0, MediaControls().MediaElement().currentTime());
@@ -737,7 +737,7 @@ TEST_F(MediaControlsImplTest, TimelineMetricsDragFromElsewhere) {
testing::RunPendingTasks();
ASSERT_TRUE(IsElementVisible(*TimelineElement()));
- ClientRect* timelineRect = TimelineElement()->getBoundingClientRect();
+ DOMRect* timelineRect = TimelineElement()->getBoundingClientRect();
ASSERT_LT(0, timelineRect->width());
EXPECT_EQ(0, MediaControls().MediaElement().currentTime());
@@ -774,7 +774,7 @@ TEST_F(MediaControlsImplTest, TimelineMetricsDragBackAndForth) {
testing::RunPendingTasks();
ASSERT_TRUE(IsElementVisible(*TimelineElement()));
- ClientRect* timelineRect = TimelineElement()->getBoundingClientRect();
+ DOMRect* timelineRect = TimelineElement()->getBoundingClientRect();
ASSERT_LT(0, timelineRect->width());
EXPECT_EQ(0, MediaControls().MediaElement().currentTime());

Powered by Google App Engine
This is Rietveld 408576698