Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2867883003: [CSS Typed OM] Delete obsolete number and length classes from Typed OM (Closed)

Created:
3 years, 7 months ago by meade_UTC10
Modified:
3 years, 7 months ago
Reviewers:
nainar, nainar1
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, ikilpatrick, rjwright, rwlbuis, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete obsolete number and length classes from Typed OM This breaks most of our layout tests, since most things depend on numbers and lengths, but it's better to be in a single half state than have two half states hanging around. BUG=545318 Review-Url: https://codereview.chromium.org/2867883003 Cr-Commit-Position: refs/heads/master@{#474925} Committed: https://chromium.googlesource.com/chromium/src/+/42110b22278552b70e9b5156148df454e77f6be5

Patch Set 1 #

Patch Set 2 : Make it compile #

Patch Set 3 : Remove obsolete tests #

Patch Set 4 : Add expectations and delete old layout tests #

Patch Set 5 : rebase #

Patch Set 6 : Fix spurious change to CSSProperties.json5 #

Patch Set 7 : remove spurious file #

Patch Set 8 : Update failing LayoutTests #

Total comments: 2

Patch Set 9 : Fix missed layout tests #

Patch Set 10 : rebase #

Patch Set 11 : Update some tests #

Patch Set 12 : Fix missed global-interface-listing-test #

Patch Set 13 : Fix more missed test expectations #

Patch Set 14 : rebase #

Patch Set 15 : Fix typo #

Patch Set 16 : fix typo #

Patch Set 17 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1198 lines, -1842 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/css-typed-om/styleMap-update-function.html View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/css-typed-om/styleMap-update-function-expected.txt View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/csspaint/registered-properties-in-custom-paint.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/csspaint/registered-properties-in-custom-paint-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/csspaint/style-first-letter-pseudo.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/csspaint/style-first-letter-pseudo-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +0 lines, -37 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/computedstyle/border-top-width.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/computedstyle/border-top-width-expected.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/computedstyle/custom-properties.html View 1 2 3 4 4 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/computedstyle/custom-properties-expected.txt View 1 2 3 4 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/computedstyle/left.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/computedstyle/left-expected.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/computedstyle/line-height.html View 1 2 3 4 2 chunks +9 lines, -9 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/computedstyle/line-height-expected.txt View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/computedstyle/numbers.html View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/computedstyle/numbers-expected.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/computedstyle/pseudo-elements.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/computedstyle/pseudo-elements-expected.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/computedstyle/width.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/computedstyle/width-expected.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/cssAngleValue.html View 1 2 3 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/cssCalcLength.html View 1 2 3 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/cssLengthValue.html View 1 2 3 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/cssNumberValue.html View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssPerspective.html View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssPerspective-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssPositionValue.html View 1 2 3 1 chunk +8 lines, -8 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/cssPositionValue-expected.txt View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssRotation.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/cssRotation-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +7 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/cssSimpleLength.html View 1 2 3 1 chunk +0 lines, -158 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssSkew.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssSkew-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssTransformValue.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +17 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssTranslation.html View 1 2 3 4 5 6 7 8 9 10 3 chunks +32 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssTranslation-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_append.html View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_delete.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_delete-expected.txt View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getAll.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getAll-expected.txt View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getProperties.html View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getProperties-expected.txt View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iteration.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iteration-expected.txt View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iterationWithModification.html View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iterationWithModification-expected.txt View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_setGet.html View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_setGet-expected.txt View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/numbers.html View 1 2 3 4 5 6 7 2 chunks +7 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/numbers-expected.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/animation-direction.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/background-image.html View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-bottom-width-expected.txt View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-left-width-expected.txt View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-right-width-expected.txt View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/border-top-width-expected.txt View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/bottom-expected.txt View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/config-templates.js View 1 2 3 2 chunks +61 lines, -61 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/height-expected.txt View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/left-expected.txt View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/right-expected.txt View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/top-expected.txt View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/transform.html View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/transform-expected.txt View 1 2 3 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/width-expected.txt View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-perspective.html View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-perspective-expected.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/styleValue-parse-basic.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/styleValue-parse-basic-expected.txt View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +0 lines, -42 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +0 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 10 chunks +0 lines, -10 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSAngleValue.h View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSAngleValue.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSAngleValue.idl View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp View 1 chunk +0 lines, -304 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSCalcLength.idl View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSLengthValue.h View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp View 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSLengthValue.idl View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSNumberValue.h View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSNumberValue.idl View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSNumericValue.h View 1 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSPerspective.h View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSPerspective.cpp View 1 2 3 2 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSPerspective.idl View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSPositionValue.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSPositionValue.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSPositionValue.idl View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSRotation.h View 1 4 chunks +17 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp View 1 4 chunks +19 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSRotation.idl View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.h View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.idl View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSSkew.h View 1 3 chunks +16 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp View 1 1 chunk +45 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSSkew.idl View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTranslation.h View 1 3 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTranslation.cpp View 1 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTranslation.idl View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.cpp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp View 3 chunks +0 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 69 (49 generated)
meade_UTC10
The bots are failing because of that silly bug where the bot_update step fails if ...
3 years, 7 months ago (2017-05-11 08:23:30 UTC) #13
meade_UTC10
nainar: Since you volunteered, PTAL!
3 years, 7 months ago (2017-05-11 08:27:32 UTC) #16
meade_UTC10
Ok, I've rebased this now. PTAL
3 years, 7 months ago (2017-05-15 06:08:24 UTC) #21
nainar
On 2017/05/15 at 06:08:24, meade wrote: > Ok, I've rebased this now. PTAL This l*tm ...
3 years, 7 months ago (2017-05-15 08:20:31 UTC) #26
meade_UTC10
Ah oops, I missed some. Fixed (I think.. will check once the bots run again)
3 years, 7 months ago (2017-05-15 09:11:19 UTC) #27
nainar1
lgtm once you can fix the failing tests https://codereview.chromium.org/2867883003/diff/140001/third_party/WebKit/LayoutTests/external/wpt/css-typed-om/styleMap-update-function.html File third_party/WebKit/LayoutTests/external/wpt/css-typed-om/styleMap-update-function.html (right): https://codereview.chromium.org/2867883003/diff/140001/third_party/WebKit/LayoutTests/external/wpt/css-typed-om/styleMap-update-function.html#newcode12 third_party/WebKit/LayoutTests/external/wpt/css-typed-om/styleMap-update-function.html:12: element.styleMap.set('width', ...
3 years, 7 months ago (2017-05-16 00:20:48 UTC) #33
nainar1
lgtm once you can fix the failing tests
3 years, 7 months ago (2017-05-16 00:20:49 UTC) #34
nainar
lgtm
3 years, 7 months ago (2017-05-17 01:34:08 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867883003/160001
3 years, 7 months ago (2017-05-18 01:09:43 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448020)
3 years, 7 months ago (2017-05-18 03:01:44 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867883003/160001
3 years, 7 months ago (2017-05-18 03:24:05 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/458554)
3 years, 7 months ago (2017-05-18 04:21:07 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867883003/240001
3 years, 7 months ago (2017-05-24 00:28:34 UTC) #51
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/276124) android_cronet on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 7 months ago (2017-05-24 00:34:34 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867883003/260001
3 years, 7 months ago (2017-05-25 05:09:29 UTC) #56
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/464211)
3 years, 7 months ago (2017-05-25 06:39:28 UTC) #58
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867883003/280001
3 years, 7 months ago (2017-05-25 06:48:31 UTC) #61
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/464252)
3 years, 7 months ago (2017-05-25 08:31:30 UTC) #63
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867883003/320001
3 years, 7 months ago (2017-05-26 01:22:10 UTC) #66
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 05:37:56 UTC) #69
Message was sent while issue was closed.
Committed patchset #17 (id:320001) as
https://chromium.googlesource.com/chromium/src/+/42110b22278552b70e9b5156148d...

Powered by Google App Engine
This is Rietveld 408576698