Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: third_party/WebKit/LayoutTests/typedcssom/computedstyle/line-height.html

Issue 2867883003: [CSS Typed OM] Delete obsolete number and length classes from Typed OM (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/typedcssom/computedstyle/line-height.html
diff --git a/third_party/WebKit/LayoutTests/typedcssom/computedstyle/line-height.html b/third_party/WebKit/LayoutTests/typedcssom/computedstyle/line-height.html
index 68c9e89471ac82a25eeec8f41fb81bfb30400f82..e3b493ffc53495805f3ebd2a3e8cc498854655f6 100644
--- a/third_party/WebKit/LayoutTests/typedcssom/computedstyle/line-height.html
+++ b/third_party/WebKit/LayoutTests/typedcssom/computedstyle/line-height.html
@@ -16,9 +16,9 @@ var computedStyleMap = getComputedStyleMap(testElement);
test(function() {
var result = computedStyleMap.get('line-height');
- assert_true(result instanceof CSSSimpleLength);
+ assert_equals(result.constructor.name, CSSUnitValue.name);
assert_equals(result.cssText, '10px');
-}, 'Getting a 10px lineHeight results in a CSSSimpleLength');
+}, 'Getting a 10px lineHeight results in a CSSUnitValue');
test(function() {
testElement.style.lineHeight = '20px';
@@ -30,28 +30,28 @@ test(function() {
test(function() {
testElement.style.lineHeight = '10%';
var result = computedStyleMap.get('line-height');
- assert_true(result instanceof CSSSimpleLength);
+ assert_equals(result.constructor.name, CSSUnitValue.name);
assert_equals(result.cssText, '10px');
-}, 'Getting a 10% lineHeight results in a CSSSimpleLength');
+}, 'Getting a 10% lineHeight results in a CSSUnitValue');
test(function() {
testElement.style.lineHeight = '0.2';
var result = computedStyleMap.get('line-height');
- assert_true(result instanceof CSSSimpleLength);
+ assert_equals(result.constructor.name, CSSUnitValue.name);
assert_equals(result.cssText, '20px');
-}, 'Getting a number lineHeight results in a CSSSimpleLength');
+}, 'Getting a number lineHeight results in a CSSUnitValue');
test(function() {
testElement.style.lineHeight = 'calc(10px + 10%)';
var result = computedStyleMap.get('line-height');
- assert_true(result instanceof CSSSimpleLength);
+ assert_equals(result.constructor.name, CSSUnitValue.name);
assert_equals(result.cssText, '20px');
-}, 'Getting a calc lineHeight results in a CSSSimpleLength');
+}, 'Getting a calc lineHeight results in a CSSUnitValue');
test(function() {
testElement.style.lineHeight = 'normal';
var result = computedStyleMap.get('line-height');
- assert_true(result instanceof CSSKeywordValue);
+ assert_equals(result.constructor.name, CSSKeywordValue.name);
assert_equals(result.cssText, 'normal');
}, 'Getting a normal lineHeight results in a CSSKeywordValue');

Powered by Google App Engine
This is Rietveld 408576698