[Typed CSSOM] New design for computed styles which includes custom properties

[Typed CSSOM]New design for computed styles which includes custom properties

Adds support for getting computed style values for custom properties from Typed CSSOM.

Changes the way we get computed styles for normal CSS properties in Typed CSSOM. Previously we hand-rolled CSStyleValues using values retrieved from ComputedStyle. Now we are getting computed style values via ComputedStyleCSSValueMapping::get (which apparently returns raw computed style values when passed a nullptr LayoutObject) and turning them into CSSStyleValues via StyleValueFactory.

Small tidy-up in StylePropertyMapReadOnly.

This CL has two outstanding test failures that will be resolved in followup CLs. Custom property behavior in InlineStylePropertyMap also needs tests, which will be added in a followup CL.

BUG=648495
Review-Url: https://codereview.chromium.org/2791193004
Cr-Commit-Position: refs/heads/master@{#471251}
Committed: https://chromium.googlesource.com/chromium/src/+/7f86224d3bc34aa39ea8cdd21ec590b6e2954806

[rjwright, 2017-04-05 02:44:38]

Description was changed from

==========
[Typed CSSOM][WIP] New design for computed styles which includes custom
properties
BUG=648495
==========

to

==========
[Typed CSSOM][WIP] New design for computed styles which includes custom
properties

Adds support for getting computed style values for custom properties from Typed
CSSOM.

Changes the way we get computed styles for normal CSS properties in Typed CSSOM.
Previously we hand-rolled CSStyleValues using values retrieved from
ComputedStyle. Now we are getting computed style values via
ComputedStyleCSSValueMapping::get (which apparently returns raw computed style
values when passed a nullptr LayoutObject) and turning them into CSSStyleValues
via StyleValueFactory.

Small tidy-up in StylePropertyMapReadOnly.

BUG=648495
==========

[rjwright, 2017-04-05 02:44:38]

rjwright@chromium.org changed reviewers:
+ alancutter@chromium.org, meade@chromium.org

[rjwright, 2017-04-05 02:45:10]

Description was changed from

==========
[Typed CSSOM][WIP] New design for computed styles which includes custom
properties

Adds support for getting computed style values for custom properties from Typed
CSSOM.

Changes the way we get computed styles for normal CSS properties in Typed CSSOM.
Previously we hand-rolled CSStyleValues using values retrieved from
ComputedStyle. Now we are getting computed style values via
ComputedStyleCSSValueMapping::get (which apparently returns raw computed style
values when passed a nullptr LayoutObject) and turning them into CSSStyleValues
via StyleValueFactory.

Small tidy-up in StylePropertyMapReadOnly.

BUG=648495
==========

to

==========
[Typed CSSOM][WIP] New design for computed styles which includes custom
properties

Adds support for getting computed style values for custom properties from Typed
CSSOM.

Changes the way we get computed styles for normal CSS properties in Typed CSSOM.
Previously we hand-rolled CSStyleValues using values retrieved from
ComputedStyle. Now we are getting computed style values via
ComputedStyleCSSValueMapping::get (which apparently returns raw computed style
values when passed a nullptr LayoutObject) and turning them into CSSStyleValues
via StyleValueFactory.

Small tidy-up in StylePropertyMapReadOnly.

This CL is a WIP because it has two outstanding test failures and two FIXMEs
that need to be resolved.

BUG=648495
==========

[alancutter (OOO until 2018), 2017-04-05 04:54:09]

Seem fine overall, will wait for final patch.

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:9:
#include "core/css/PropertyRegistry.h"
I don't think this include is required.

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:44: //
This could cause the node to be blown away.
Add test case for this. (Set display to none).

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:78: //
FIXME(rjwright): propertyRegistry is nullptr in stable Chrome.
I don't think anything will change here, no need for FIXME.

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp:92:
exceptionState.throwTypeError("Invalid propertyName: " + customPropertyName);
Is this part still WIP for this patch?

[alancutter (OOO until 2018), 2017-04-05 05:00:16]

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/typedcssom/computedstyle/computedStylePropertyMap.html
(right):

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/typedcssom/computedstyle/computedStylePropertyMap.html:45:
}, 'has() return false for an unsupported property.');
max-zoom is technically a descriptor, not a property. If you eventually expose
Typed OM for style rules I would expect max-zoom to work for viewport at-rules.
https://developer.mozilla.org/en/docs/Web/CSS/@viewport

[meade_UTC10, 2017-04-06 03:47:32]

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/typedcssom/computedstyle/custom-properties.html
(right):

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/typedcssom/computedstyle/custom-properties.html:58:
</style>
Can this be above the script element, and the two script elements merged? Or
does that cause ordering issues?

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/typedcssom/computedstyle/custom-properties.html:83:
// FIXME(rjwright): I thought this was fixed!
Perhaps a more helpful comment? :p

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/typedcssom/computedstyle/custom-properties.html:99:
function t2Callback() {
If you move the calculation of the image path into the first script block, does
this mean you no longer need the onreadystatechange below?

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:13:
#include "core/css/cssom/CSSSimpleLength.h"
These other specific types probably aren't required any more either now.

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:74:
ExceptionState& exceptionState) {
You're not using the exception state - no need to add it here. Removing will let
you revert some of the other files in this CL.

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp (left):

https://codereview.chromium.org/2791193004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp:97:
*cssValue);
It seems like removing this is moving backwards?

[rjwright, 2017-05-04 06:18:54]

The CQ bit was checked by rjwright@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 06:19:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rjwright, 2017-05-09 01:16:27]

rjwright@chromium.org changed reviewers:
+ nainar@chromium.org

[rjwright, 2017-05-09 01:17:54]

Description was changed from

==========
[Typed CSSOM][WIP] New design for computed styles which includes custom
properties

Adds support for getting computed style values for custom properties from Typed
CSSOM.

Changes the way we get computed styles for normal CSS properties in Typed CSSOM.
Previously we hand-rolled CSStyleValues using values retrieved from
ComputedStyle. Now we are getting computed style values via
ComputedStyleCSSValueMapping::get (which apparently returns raw computed style
values when passed a nullptr LayoutObject) and turning them into CSSStyleValues
via StyleValueFactory.

Small tidy-up in StylePropertyMapReadOnly.

This CL is a WIP because it has two outstanding test failures and two FIXMEs
that need to be resolved.

BUG=648495
==========

to

==========
[Typed CSSOM]New design for computed styles which includes custom properties

Adds support for getting computed style values for custom properties from Typed
CSSOM.

Changes the way we get computed styles for normal CSS properties in Typed CSSOM.
Previously we hand-rolled CSStyleValues using values retrieved from
ComputedStyle. Now we are getting computed style values via
ComputedStyleCSSValueMapping::get (which apparently returns raw computed style
values when passed a nullptr LayoutObject) and turning them into CSSStyleValues
via StyleValueFactory.

Small tidy-up in StylePropertyMapReadOnly.

This CL has two outstanding test failures that will be resolved in followup CLs.
Custom property behavior in InlineStylePropertyMap also needs tests, which will
be added in a followup CL.

BUG=648495
==========

[rjwright, 2017-05-09 01:24:04]

OK folks, I think I have addressed all the comments.

I have re-instated the custom property logic in InlineStylePropertyMap, but it
is now exposed where it wasn't before. I will revisit it and add tests for it in
the next CL.

There are two failing layout tests. I will resolve those in a followup CL.

I don't know of a good way to test when and why UpdateStyleAndLayoutTreeForNode
changes/deletes the node or it's computed style. This behavior should already be
tested for its use in CSSComputedStyleDeclaration::GetPropertyCSSValue, but I
need to double check that.

PTAL.

[rjwright, 2017-05-09 04:40:29]

On 2017/05/09 01:24:15, rjwright wrote:

Eddy and Alan, please take another look.

Naina would you please also do a quick pass for any obvious issues. Do you have
any insight into the failing image test case in custom-properties.html?

[meade_UTC10, 2017-05-09 04:59:36]

lgtm with nits on my side.

https://codereview.chromium.org/2791193004/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2791193004/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:34: //
This could cause the node to be blown away.
Nit: Add a comment here pointing to where this was copied from :)

https://codereview.chromium.org/2791193004/diff/160001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2791193004/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp:77:
}
nit: unrelated change?

https://codereview.chromium.org/2791193004/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2791193004/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp:89: // Make
sure it is tested and correct.
Nit: please delete this TODO before submitting :)

[rjwright, 2017-05-09 05:25:37]

Nits done, Eddy.

I just went and looked at the "failing" line height test, where a number
line-height returns a CSSSimpleLength computed value. It turns out that is the
correct behavior, and matches getComputedStyle. I had misinterpreted the spec,
thinking that a number value wasn't classified as a length. I have changed the
test expectation now.

[rjwright, 2017-05-09 05:26:06]

The CQ bit was checked by rjwright@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 05:26:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-05-09 06:07:28]

ComputedStylePropertyMap lgtm

https://codereview.chromium.org/2791193004/diff/200001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/typedcssom/computedstyle/custom-properties.html
(right):

https://codereview.chromium.org/2791193004/diff/200001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/typedcssom/computedstyle/custom-properties.html:81:
// FIXME(rjwright): This test currently fails. Need to find out why and fix it.
Don't think fixing this is on you - file a bug for it. Seems like a custom prop
issue

https://codereview.chromium.org/2791193004/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2791193004/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:18: //
Seems to only support before, after, backdrop, first-letter. See
Those are the only ones that need to be supported here. So this is correct.

[rjwright, 2017-05-09 06:34:07]

Thanks Naina. Done.

[rjwright, 2017-05-10 02:10:54]

The CQ bit was checked by rjwright@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 02:12:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 04:14:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 04:14:11]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[alancutter (OOO until 2018), 2017-05-11 04:34:04]

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/typedcssom/computedstyle/custom-properties.html
(right):

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/typedcssom/computedstyle/custom-properties.html:59:
// properties.
This might get fixed by: https://codereview.chromium.org/2873943002

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:33: //
CSSComputedStyleDeclaration::GetPropertyCSSValue.
It doesn't look like it's necessary to copy this code from
CSSComputedStyleDeclaration, they could turned be made into static helper
functions instead and then we can avoid having these comments.

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:50:
CSSStyleValueVector style_value_vector;
This is never used.

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:55:
property_id, *style, nullptr /* layoutObject */);
This should say "layout_object".

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
(right):

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h:58: const
ComputedStyle* UpdateStyle() const;
Does this method need to be const?

[meade_UTC10, 2017-05-11 08:31:24]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-05-11 08:31:24]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
nainar@chromium.org
Link to the patchset: https://codereview.chromium.org/2791193004/#ps260001
(title: "remove unneeded arg in test calls")

[meade_UTC10, 2017-05-11 08:31:29]

The CQ bit was unchecked by meade@chromium.org

[rjwright, 2017-05-12 04:47:34]

Thanks heaps Alan

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/typedcssom/computedstyle/custom-properties.html
(right):

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/typedcssom/computedstyle/custom-properties.html:59:
// properties.
On 2017/05/11 04:34:03, alancutter wrote:
> This might get fixed by: https://codereview.chromium.org/2873943002

Awesome. Thanks. I will rebase and see.

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:33: //
CSSComputedStyleDeclaration::GetPropertyCSSValue.
On 2017/05/11 04:34:04, alancutter wrote:
> It doesn't look like it's necessary to copy this code from
> CSSComputedStyleDeclaration, they could turned be made into static helper
> functions instead and then we can avoid having these comments.

Only a small amount of code is copied from there. I didn't copy and paste it, I
looked to the existing code to find out how to do this logic properly. I think
it's clearer to have this logic remain here. I thought the comment would be
useful to keep a record of the relationship between the two, but it's not
absolutely necessary.

Perhaps I can combine then though. May I look into it in a follow-up?

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:50:
CSSStyleValueVector style_value_vector;
On 2017/05/11 04:34:04, alancutter wrote:
> This is never used.

Done.

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:55:
property_id, *style, nullptr /* layoutObject */);
On 2017/05/11 04:34:04, alancutter wrote:
> This should say "layout_object".

Done.

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
(right):

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h:58: const
ComputedStyle* UpdateStyle() const;
On 2017/05/11 04:34:04, alancutter wrote:
> Does this method need to be const?

Sasha asked me ages ago to make as much stuff const as possible. I'm not sure
what the best practice is. Eddy, do you know?

[alancutter (OOO until 2018), 2017-05-12 04:53:16]

lgtm

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:33: //
CSSComputedStyleDeclaration::GetPropertyCSSValue.
On 2017/05/12 at 04:47:34, rjwright wrote:
> On 2017/05/11 04:34:04, alancutter wrote:
> > It doesn't look like it's necessary to copy this code from
> > CSSComputedStyleDeclaration, they could turned be made into static helper
> > functions instead and then we can avoid having these comments.
> 
> Only a small amount of code is copied from there. I didn't copy and paste it,
I looked to the existing code to find out how to do this logic properly. I think
it's clearer to have this logic remain here. I thought the comment would be
useful to keep a record of the relationship between the two, but it's not
absolutely necessary.
> 
> Perhaps I can combine then though. May I look into it in a follow-up?

A low priority follow up patch SGTM.

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
(right):

https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h:58: const
ComputedStyle* UpdateStyle() const;
On 2017/05/12 at 04:47:34, rjwright wrote:
> On 2017/05/11 04:34:04, alancutter wrote:
> > Does this method need to be const?
> 
> Sasha asked me ages ago to make as much stuff const as possible. I'm not sure
what the best practice is. Eddy, do you know?

I think what Sasha meant was to make types as const as possible. Marking methods
as const is a little bit different.

I pointed this one out because it's very strange for a const method to have a
name like "Update", the name implies mutation.

[rjwright, 2017-05-12 05:05:50]

>
https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
> (right):
> 
>
https://codereview.chromium.org/2791193004/diff/260001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h:58: const
> ComputedStyle* UpdateStyle() const;
> On 2017/05/12 at 04:47:34, rjwright wrote:
> > On 2017/05/11 04:34:04, alancutter wrote:
> > > Does this method need to be const?
> > 
> > Sasha asked me ages ago to make as much stuff const as possible. I'm not
sure
> what the best practice is. Eddy, do you know?
> 
> I think what Sasha meant was to make types as const as possible. Marking
methods
> as const is a little bit different.
> 
> I pointed this one out because it's very strange for a const method to have a
> name like "Update", the name implies mutation.

Ohh I see what you mean now. OK, will fix.

[rjwright, 2017-05-12 05:27:49]

The CQ bit was checked by rjwright@chromium.org

[rjwright, 2017-05-12 05:27:50]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
nainar@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2791193004/#ps300001
(title: "Make UpdateStyle non-const")

[commit-bot: I haz the power, 2017-05-12 05:28:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 06:26:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 06:26:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[meade_UTC10, 2017-05-12 06:30:03]

The CQ bit was checked by meade@chromium.org

[commit-bot: I haz the power, 2017-05-12 06:30:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 08:41:27]

CQ is committing da patch.

Bot data: {"patchset_id": 300001, "attempt_start_ts": 1494570603478070,
"parent_rev": "a50d914e18c636fb8a37bf622ef8bd8728c9d2b7", "commit_rev":
"7f86224d3bc34aa39ea8cdd21ec590b6e2954806"}

[commit-bot: I haz the power, 2017-05-12 08:41:39]

Description was changed from

==========
[Typed CSSOM]New design for computed styles which includes custom properties

Adds support for getting computed style values for custom properties from Typed
CSSOM.

Changes the way we get computed styles for normal CSS properties in Typed CSSOM.
Previously we hand-rolled CSStyleValues using values retrieved from
ComputedStyle. Now we are getting computed style values via
ComputedStyleCSSValueMapping::get (which apparently returns raw computed style
values when passed a nullptr LayoutObject) and turning them into CSSStyleValues
via StyleValueFactory.

Small tidy-up in StylePropertyMapReadOnly.

This CL has two outstanding test failures that will be resolved in followup CLs.
Custom property behavior in InlineStylePropertyMap also needs tests, which will
be added in a followup CL.

BUG=648495
==========

to

==========
[Typed CSSOM]New design for computed styles which includes custom properties

Adds support for getting computed style values for custom properties from Typed
CSSOM.

Changes the way we get computed styles for normal CSS properties in Typed CSSOM.
Previously we hand-rolled CSStyleValues using values retrieved from
ComputedStyle. Now we are getting computed style values via
ComputedStyleCSSValueMapping::get (which apparently returns raw computed style
values when passed a nullptr LayoutObject) and turning them into CSSStyleValues
via StyleValueFactory.

Small tidy-up in StylePropertyMapReadOnly.

This CL has two outstanding test failures that will be resolved in followup CLs.
Custom property behavior in InlineStylePropertyMap also needs tests, which will
be added in a followup CL.

BUG=648495

Review-Url: https://codereview.chromium.org/2791193004
Cr-Commit-Position: refs/heads/master@{#471251}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f86224d3bc34aa39ea8cdd21ec5...
==========

[commit-bot: I haz the power, 2017-05-12 08:41:40]

Committed patchset #16 (id:300001) as
https://chromium.googlesource.com/chromium/src/+/7f86224d3bc34aa39ea8cdd21ec5...