Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h

Issue 2867883003: [CSS Typed OM] Delete obsolete number and length classes from Typed OM (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h b/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h
index 6b8cc09938187a417dc4626de3b9f8b3ecc2c397..5b2226e346feac64b1beb1caf80b79569e2390e5 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h
@@ -50,7 +50,12 @@ class CORE_EXPORT CSSTransformComponent
bool is2D() const { return Is2DComponentType(GetType()); }
- String toString() const { return ToCSSValue()->CssText(); }
+ virtual String toString() const {
+ const CSSValue* result = ToCSSValue();
+ // TODO(meade): Remove this once all the number and length types are
+ // rewritten.
+ return result ? result->CssText() : "";
+ }
virtual CSSFunctionValue* ToCSSValue() const = 0;
virtual CSSMatrixComponent* asMatrix() const = 0;

Powered by Google App Engine
This is Rietveld 408576698