Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl

Issue 2867883003: [CSS Typed OM] Delete obsolete number and length classes from Typed OM (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl
index 7c90430ad536ecdf28a7d636accd6f80079dfa13..2252e28842451bf31f44cf81ef6188fa67d81bde 100644
--- a/third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl
@@ -7,7 +7,6 @@
#include "core/css/CSSPropertyMetadata.h"
#include "core/css/cssom/CSSOMKeywords.h"
#include "core/css/cssom/CSSKeywordValue.h"
-#include "core/css/cssom/CSSLengthValue.h"
#include "core/css/cssom/CSSStyleValue.h"
namespace blink {
@@ -17,10 +16,11 @@ bool CSSOMTypes::PropertyCanTake(CSSPropertyID id,
// Shortcut special case.
if (styleValue.GetType() == CSSStyleValue::kSimpleLengthType ||
styleValue.GetType() == CSSStyleValue::kCalcLengthType) {
- if (ToCSSLengthValue(styleValue).ContainsPercent() &&
- !CSSPropertyMetadata::PropertySupportsPercentage(id)) {
- return false;
- }
+ // TODO(meade): Rewrite this once the new length types are spec'd.
+ // if (ToCSSLengthValue(styleValue).ContainsPercent() &&
+ // !CSSPropertyMetadata::PropertySupportsPercentage(id)) {
+ // return false;
+ // }
} else if (styleValue.GetType() == CSSStyleValue::kKeywordType) {
// Keywords are also handled differently.
return CSSOMKeywords::ValidKeywordForProperty(

Powered by Google App Engine
This is Rietveld 408576698