Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp

Issue 2867883003: [CSS Typed OM] Delete obsolete number and length classes from Typed OM (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp b/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp
index 989d2e8ae240f11ff8373588729f2396b16a0e1d..8fa84ef432d644124b31e16b87e0d27662ff7456 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp
+++ b/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp
@@ -37,7 +37,11 @@ bool CSSTransformValue::is2D() const {
const CSSValue* CSSTransformValue::ToCSSValue() const {
CSSValueList* transform_css_value = CSSValueList::CreateSpaceSeparated();
for (size_t i = 0; i < transform_components_.size(); i++) {
- transform_css_value->Append(*transform_components_[i]->ToCSSValue());
+ const CSSValue* component = transform_components_[i]->ToCSSValue();
+ // TODO(meade): Remove this check once numbers and lengths are rewritten.
+ if (!component)
+ return nullptr;
+ transform_css_value->Append(*component);
}
return transform_css_value;
}

Powered by Google App Engine
This is Rietveld 408576698