Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSPerspective.cpp

Issue 2867883003: [CSS Typed OM] Delete obsolete number and length classes from Typed OM (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSPerspective.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSPerspective.cpp b/third_party/WebKit/Source/core/css/cssom/CSSPerspective.cpp
index 725b2b7e30dce72cb5762d4b84070e25c1541ce9..7c688000482ee8e66dacc0fb4bf24775d15ac94a 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSPerspective.cpp
+++ b/third_party/WebKit/Source/core/css/cssom/CSSPerspective.cpp
@@ -8,11 +8,11 @@
namespace blink {
-CSSPerspective* CSSPerspective::Create(const CSSLengthValue* length,
+CSSPerspective* CSSPerspective::Create(const CSSNumericValue* length,
ExceptionState& exception_state) {
if (length->ContainsPercent()) {
exception_state.ThrowTypeError(
- "CSSPerspective does not support CSSLengthValues with percent units");
+ "CSSPerspective does not support CSSNumericValues with percent units");
return nullptr;
}
return new CSSPerspective(length);
@@ -21,16 +21,17 @@ CSSPerspective* CSSPerspective::Create(const CSSLengthValue* length,
CSSPerspective* CSSPerspective::FromCSSValue(const CSSFunctionValue& value) {
DCHECK_EQ(value.FunctionType(), CSSValuePerspective);
DCHECK_EQ(value.length(), 1U);
- CSSLengthValue* length =
- CSSLengthValue::FromCSSValue(ToCSSPrimitiveValue(value.Item(0)));
+ CSSNumericValue* length =
+ CSSNumericValue::FromCSSValue(ToCSSPrimitiveValue(value.Item(0)));
DCHECK(!length->ContainsPercent());
return new CSSPerspective(length);
}
CSSFunctionValue* CSSPerspective::ToCSSValue() const {
- CSSFunctionValue* result = CSSFunctionValue::Create(CSSValuePerspective);
- result->Append(*length_->ToCSSValue());
- return result;
+ return nullptr;
+ // CSSFunctionValue* result = CSSFunctionValue::Create(CSSValuePerspective);
+ // result->Append(*length_->ToCSSValue());
+ // return result;
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSPerspective.h ('k') | third_party/WebKit/Source/core/css/cssom/CSSPerspective.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698