Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2860163005: chromeos: gets rid of wm_screen_util (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: gets rid of wm_screen_util And folds implementation back into ash/screen_util. BUG=671246 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2860163005 Cr-Commit-Position: refs/heads/master@{#469687} Committed: https://chromium.googlesource.com/chromium/src/+/00f0b896b1fea3226f9cbbdfd592edc39b49f158

Patch Set 1 #

Patch Set 2 : include #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -171 lines) Patch
M ash/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/app_list/app_list_presenter_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M ash/root_window_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/screen_util.h View 1 chunk +8 lines, -4 lines 1 comment Download
M ash/screen_util.cc View 3 chunks +15 lines, -2 lines 0 comments Download
M ash/screen_util_unittest.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 6 chunks +12 lines, -9 lines 0 comments Download
M ash/system/toast/toast_manager_unittest.cc View 6 chunks +12 lines, -6 lines 0 comments Download
M ash/wm/default_state.cc View 12 chunks +25 lines, -15 lines 0 comments Download
M ash/wm/lock_window_state.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M ash/wm/overview/window_grid.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/window_positioner.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M ash/wm/window_positioning_utils.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M ash/wm/window_state.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M ash/wm/window_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
D ash/wm/wm_screen_util.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ash/wm/wm_screen_util.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 5 chunks +7 lines, -4 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 5 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
sky
3 years, 7 months ago (2017-05-05 13:36:50 UTC) #5
msw
lgtm https://codereview.chromium.org/2860163005/diff/20001/ash/screen_util.h File ash/screen_util.h (right): https://codereview.chromium.org/2860163005/diff/20001/ash/screen_util.h#newcode41 ash/screen_util.h:41: DISALLOW_IMPLICIT_CONSTRUCTORS(ScreenUtil); Nice, I never knew about this
3 years, 7 months ago (2017-05-05 16:58:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860163005/20001
3 years, 7 months ago (2017-05-05 17:00:23 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 17:06:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/00f0b896b1fea3226f9cbbdfd592...

Powered by Google App Engine
This is Rietveld 408576698