Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2858153004: Rename |m_callback| to |callback_| in IDL bindings. (Closed)

Created:
3 years, 7 months ago by Łukasz Anforowicz
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename |m_callback| to |callback_| in IDL bindings. This CL was generated mechanically with: $ git grep -l m_callback -- third_party/WebKit/Source | \ xargs -n 1 sed -i -e 's/\bm_callback\b/callback_/g' No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2858153004 Cr-Commit-Position: refs/heads/master@{#469538} Committed: https://chromium.googlesource.com/chromium/src/+/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -73 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Łukasz Anforowicz
haraken@, could you PTAL? This is basically an equivalent of https://codereview.chromium.org/2857853007 that covers |m_callback|.
3 years, 7 months ago (2017-05-04 20:02:09 UTC) #4
haraken
LGTM
3 years, 7 months ago (2017-05-04 23:56:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858153004/1
3 years, 7 months ago (2017-05-05 00:03:57 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 00:15:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c9672e28ad57ca92994dfaa20c7b...

Powered by Google App Engine
This is Rietveld 408576698