| OLD | NEW |
|---|
| 1 /* | 1 /* |
| 2 * Copyright (c) 2009, 2012 Google Inc. All rights reserved. | 2 * Copyright (c) 2009, 2012 Google Inc. All rights reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions are | 5 * modification, are permitted provided that the following conditions are |
| 6 * met: | 6 * met: |
| 7 * | 7 * |
| 8 * * Redistributions of source code must retain the above copyright | 8 * * Redistributions of source code must retain the above copyright |
| 9 * notice, this list of conditions and the following disclaimer. | 9 * notice, this list of conditions and the following disclaimer. |
| 10 * * Redistributions in binary form must reproduce the above | 10 * * Redistributions in binary form must reproduce the above |
| (...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 62 exception_catcher.SetVerbose(true); | 62 exception_catcher.SetVerbose(true); |
| 63 | 63 |
| 64 v8::Local<v8::Value> result; | 64 v8::Local<v8::Value> result; |
| 65 // FIXME: This comment doesn't make much sense given what the code is actually | 65 // FIXME: This comment doesn't make much sense given what the code is actually |
| 66 // doing. | 66 // doing. |
| 67 // | 67 // |
| 68 // Step 6: If the error callback returns false, then move on to the next | 68 // Step 6: If the error callback returns false, then move on to the next |
| 69 // statement, if any, or onto the next overall step otherwise. Otherwise, | 69 // statement, if any, or onto the next overall step otherwise. Otherwise, |
| 70 // the error callback did not return false, or there was no error callback. | 70 // the error callback did not return false, or there was no error callback. |
| 71 // Jump to the last step in the overall steps. | 71 // Jump to the last step in the overall steps. |
| 72 if (!V8ScriptRunner::CallFunction(m_callback.NewLocal(isolate), | 72 if (!V8ScriptRunner::CallFunction(callback_.NewLocal(isolate), |
| 73 ExecutionContext::From(script_state_.Get()), | 73 ExecutionContext::From(script_state_.Get()), |
| 74 script_state_->GetContext()->Global(), | 74 script_state_->GetContext()->Global(), |
| 75 WTF_ARRAY_LENGTH(argv), argv, isolate) | 75 WTF_ARRAY_LENGTH(argv), argv, isolate) |
| 76 .ToLocal(&result)) | 76 .ToLocal(&result)) |
| 77 return true; | 77 return true; |
| 78 bool value; | 78 bool value; |
| 79 if (!result->BooleanValue(isolate->GetCurrentContext()).To(&value)) | 79 if (!result->BooleanValue(isolate->GetCurrentContext()).To(&value)) |
| 80 return true; | 80 return true; |
| 81 return value; | 81 return value; |
| 82 } | 82 } |
| 83 | 83 |
| 84 } // namespace blink | 84 } // namespace blink |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 2858153004:
Rename |m_callback| to |callback_| in IDL bindings. (Closed)
