Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2857853007: Rename |m_scriptState| to |script_state_| in IDL bindings. (Closed)

Created:
3 years, 7 months ago by Łukasz Anforowicz
Modified:
3 years, 7 months ago
Reviewers:
haraken, esprehn
CC:
chromium-reviews, blink-reviews, kinuko+watch, blink-reviews-bindings_chromium.org, dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename |m_scriptState| to |script_state_| in IDL bindings. This CL was generated mechanically with: $ git grep -l m_scriptState -- third_party/WebKit/Source | \ xargs -n 1 sed -i -e 's/\bm_scriptState\b/script_state_/g' No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2857853007 Cr-Commit-Position: refs/heads/master@{#469363} Committed: https://chromium.googlesource.com/chromium/src/+/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -147 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_callback_function.py View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp View 9 chunks +47 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/bindings/ScriptState.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Łukasz Anforowicz
esprehn@, could you PTAL? The clang-based renaming tool skipped renaming identifiers in generated code - ...
3 years, 7 months ago (2017-05-04 16:25:11 UTC) #7
haraken
LGTM
3 years, 7 months ago (2017-05-04 16:28:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857853007/1
3 years, 7 months ago (2017-05-04 16:56:14 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 17:05:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8d0c60dcfe3e5f091be962645a7a...

Powered by Google App Engine
This is Rietveld 408576698