Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp

Issue 2858153004: Rename |m_callback| to |callback_| in IDL bindings. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp b/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
index 4d901982b8fcc43748df79a5b7113a5c5e0e79db..37706f460512582a23b3868d2c7a73c65fc934e1 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
@@ -31,16 +31,16 @@ VoidCallbackFunctionInterfaceArg* VoidCallbackFunctionInterfaceArg::Create(Scrip
VoidCallbackFunctionInterfaceArg::VoidCallbackFunctionInterfaceArg(ScriptState* scriptState, v8::Local<v8::Function> callback)
: script_state_(scriptState),
- m_callback(scriptState->GetIsolate(), this, callback) {
- DCHECK(!m_callback.IsEmpty());
+ callback_(scriptState->GetIsolate(), this, callback) {
+ DCHECK(!callback_.IsEmpty());
}
DEFINE_TRACE_WRAPPERS(VoidCallbackFunctionInterfaceArg) {
- visitor->TraceWrappers(m_callback.Cast<v8::Value>());
+ visitor->TraceWrappers(callback_.Cast<v8::Value>());
}
bool VoidCallbackFunctionInterfaceArg::call(ScriptWrappable* scriptWrappable, HTMLDivElement* divElement) {
- if (m_callback.IsEmpty())
+ if (callback_.IsEmpty())
return false;
if (!script_state_->ContextIsValid())
@@ -68,7 +68,7 @@ bool VoidCallbackFunctionInterfaceArg::call(ScriptWrappable* scriptWrappable, HT
exceptionCatcher.SetVerbose(true);
v8::Local<v8::Value> v8ReturnValue;
- if (!V8ScriptRunner::CallFunction(m_callback.NewLocal(isolate),
+ if (!V8ScriptRunner::CallFunction(callback_.NewLocal(isolate),
context,
thisValue,
1,

Powered by Google App Engine
This is Rietveld 408576698