Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp

Issue 2858153004: Rename |m_callback| to |callback_| in IDL bindings. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp b/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
index 4c36ae51c271b1b7cfd415d3aaafad437ea823e7..946c9caa676bc08bc8b3f912d1324ae93210cb98 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
@@ -32,16 +32,16 @@ LongCallbackFunction* LongCallbackFunction::Create(ScriptState* scriptState, v8:
LongCallbackFunction::LongCallbackFunction(ScriptState* scriptState, v8::Local<v8::Function> callback)
: script_state_(scriptState),
- m_callback(scriptState->GetIsolate(), this, callback) {
- DCHECK(!m_callback.IsEmpty());
+ callback_(scriptState->GetIsolate(), this, callback) {
+ DCHECK(!callback_.IsEmpty());
}
DEFINE_TRACE_WRAPPERS(LongCallbackFunction) {
- visitor->TraceWrappers(m_callback.Cast<v8::Value>());
+ visitor->TraceWrappers(callback_.Cast<v8::Value>());
}
bool LongCallbackFunction::call(ScriptWrappable* scriptWrappable, int32_t num1, int32_t num2, int32_t& returnValue) {
- if (m_callback.IsEmpty())
+ if (callback_.IsEmpty())
return false;
if (!script_state_->ContextIsValid())
@@ -70,7 +70,7 @@ bool LongCallbackFunction::call(ScriptWrappable* scriptWrappable, int32_t num1,
exceptionCatcher.SetVerbose(true);
v8::Local<v8::Value> v8ReturnValue;
- if (!V8ScriptRunner::CallFunction(m_callback.NewLocal(isolate),
+ if (!V8ScriptRunner::CallFunction(callback_.NewLocal(isolate),
context,
thisValue,
2,

Powered by Google App Engine
This is Rietveld 408576698