Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

Issue 2858153004: Rename |m_callback| to |callback_| in IDL bindings. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
index c49d343595b5d17f3113210b9117820bbf3b5db0..263ac1b9581ae08a64a6385919d52be17dd2136e 100644
--- a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
@@ -20,16 +20,16 @@ namespace blink {
{{cpp_class}}::{{cpp_class}}(ScriptState* scriptState, v8::Local<v8::Function> callback)
: script_state_(scriptState),
- m_callback(scriptState->GetIsolate(), this, callback) {
- DCHECK(!m_callback.IsEmpty());
+ callback_(scriptState->GetIsolate(), this, callback) {
+ DCHECK(!callback_.IsEmpty());
}
DEFINE_TRACE_WRAPPERS({{cpp_class}}) {
- visitor->TraceWrappers(m_callback.Cast<v8::Value>());
+ visitor->TraceWrappers(callback_.Cast<v8::Value>());
}
bool {{cpp_class}}::call({{argument_declarations | join(', ')}}) {
- if (m_callback.IsEmpty())
+ if (callback_.IsEmpty())
return false;
if (!script_state_->ContextIsValid())
@@ -64,7 +64,7 @@ bool {{cpp_class}}::call({{argument_declarations | join(', ')}}) {
exceptionCatcher.SetVerbose(true);
v8::Local<v8::Value> v8ReturnValue;
- if (!V8ScriptRunner::CallFunction(m_callback.NewLocal(isolate),
+ if (!V8ScriptRunner::CallFunction(callback_.NewLocal(isolate),
context,
thisValue,
{{arguments | length}},

Powered by Google App Engine
This is Rietveld 408576698