Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl

Issue 2858153004: Rename |m_callback| to |callback_| in IDL bindings. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
index dd7ea71675840f4861aaa444e008015e207a95e9..c0d906cbd888ad5ce4d7c9ae5fa428fbe4ae9eec 100644
--- a/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
@@ -11,7 +11,7 @@ namespace blink {
{{v8_class}}::{{v8_class}}(v8::Local<v8::Function> callback, ScriptState* scriptState)
: script_state_(scriptState) {
- m_callback.Set(scriptState->GetIsolate(), callback);
+ callback_.Set(scriptState->GetIsolate(), callback);
}
{{v8_class}}::~{{v8_class}}() {}
@@ -53,7 +53,7 @@ DEFINE_TRACE({{v8_class}}) {
{% if method.idl_type == 'boolean' %}
v8::TryCatch exceptionCatcher(isolate);
exceptionCatcher.SetVerbose(true);
- V8ScriptRunner::CallFunction(m_callback.NewLocal(isolate),
+ V8ScriptRunner::CallFunction(callback_.NewLocal(isolate),
executionContext,
{{this_handle_parameter}},
{{method.arguments | length}},
@@ -61,7 +61,7 @@ DEFINE_TRACE({{v8_class}}) {
isolate);
return !exceptionCatcher.HasCaught();
{% else %}{# void #}
- V8ScriptRunner::CallFunction(m_callback.NewLocal(isolate),
+ V8ScriptRunner::CallFunction(callback_.NewLocal(isolate),
ExecutionContext::From(script_state_.Get()),
{{this_handle_parameter}},
{{method.arguments | length}},

Powered by Google App Engine
This is Rietveld 408576698