Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8.

Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8.

This is a prerequisite to migrate v8 from base::WorkerPool to
base::TaskScheduler.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584
Review-Url: https://codereview.chromium.org/2852373004
Cr-Commit-Position: refs/heads/master@{#470007}
Committed: https://chromium.googlesource.com/chromium/src/+/09a43efb68e4412a8e091272df60eef6f50ac355

[fdoray, 2017-05-02 21:19:17]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2017-05-02 21:19:42]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, robliao@chromium.org

[fdoray, 2017-05-02 21:19:43]

PTAL

[commit-bot: I haz the power, 2017-05-02 21:19:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 22:44:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 22:44:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2017-05-03 12:04:46]

Description was changed from

==========
Use ScopedTaskEnvironment instead of MessageLoopFor in tests that use v8.

This is a prerequisite to migrate v8 from base::WorkerPool to
base::TaskScheduler.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
==========

to

==========
Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8.

This is a prerequisite to migrate v8 from base::WorkerPool to
base::TaskScheduler.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
==========

[fdoray, 2017-05-03 12:26:59]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 12:27:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 13:52:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 13:52:59]

Dry run: This issue passed the CQ dry run.

[gab, 2017-05-03 17:38:36]

lgtm but make sure OWNERS take a look at this one as they are some non trivial
changes here

https://codereview.chromium.org/2852373004/diff/40001/chrome/test/base/v8_uni...
File chrome/test/base/v8_unit_test.cc (left):

https://codereview.chromium.org/2852373004/diff/40001/chrome/test/base/v8_uni...
chrome/test/base/v8_unit_test.cc:206: loop_ =
base::MakeUnique<base::MessageLoop>();
That's peculiar. Should check with owners if there was a reason to create
MessageLoop last.

https://codereview.chromium.org/2852373004/diff/40001/content/test/blink_test...
File content/test/blink_test_environment.cc (right):

https://codereview.chromium.org/2852373004/diff/40001/content/test/blink_test...
content/test/blink_test_environment.cc:42: // would go through Java.
// On Android, Java pumps UI messages.

https://codereview.chromium.org/2852373004/diff/40001/content/test/blink_test...
content/test/blink_test_environment.cc:48: // ScopedTaskEnvironment.
Move this comment to the member and make both of them regular members (no reason
for them to be std::unique_ptr anymore IMO)...

[fdoray, 2017-05-03 18:13:00]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 18:14:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 19:43:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 19:43:02]

Dry run: This issue passed the CQ dry run.

[fdoray, 2017-05-03 20:48:43]

fdoray@chromium.org changed reviewers:
+ jochen@chromium.org, sky@chromium.org

[fdoray, 2017-05-03 20:48:44]

sky@chromium.org: Please review changes in chrome/test/base/,
content/public/test/, content/test/, mojo/

jochen@chromium.org: Please review changes in extensions/, gin/

https://codereview.chromium.org/2852373004/diff/40001/content/test/blink_test...
File content/test/blink_test_environment.cc (right):

https://codereview.chromium.org/2852373004/diff/40001/content/test/blink_test...
content/test/blink_test_environment.cc:42: // would go through Java.
On 2017/05/03 17:38:36, gab wrote:
> // On Android, Java pumps UI messages.

Done.

https://codereview.chromium.org/2852373004/diff/40001/content/test/blink_test...
content/test/blink_test_environment.cc:48: // ScopedTaskEnvironment.
On 2017/05/03 17:38:36, gab wrote:
> Move this comment to the member and make both of them regular members (no
reason
> for them to be std::unique_ptr anymore IMO)...

Done.

https://codereview.chromium.org/2852373004/diff/60001/chrome/test/base/v8_uni...
File chrome/test/base/v8_unit_test.cc (left):

https://codereview.chromium.org/2852373004/diff/60001/chrome/test/base/v8_uni...
chrome/test/base/v8_unit_test.cc:206: loop_ =
base::MakeUnique<base::MessageLoop>();
Why was this initialized at the end of SetUp() before?

[sky, 2017-05-04 02:58:55]

https://codereview.chromium.org/2852373004/diff/60001/content/public/test/ren...
File content/public/test/render_view_test.cc (right):

https://codereview.chromium.org/2852373004/diff/60001/content/public/test/ren...
content/public/test/render_view_test.cc:159: void
RenderViewTest::ProcessPendingMessages() {
How about removing this function entirely and having callers use
base::RunLoop().RunUntilIdle() directly?

[jochen (gone - plz use gerrit), 2017-05-05 14:26:52]

gin and extensions lgtm

[fdoray, 2017-05-08 15:21:45]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 15:22:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-05-08 15:22:08]

sky@: Please take another look.

https://codereview.chromium.org/2852373004/diff/60001/content/public/test/ren...
File content/public/test/render_view_test.cc (right):

https://codereview.chromium.org/2852373004/diff/60001/content/public/test/ren...
content/public/test/render_view_test.cc:159: void
RenderViewTest::ProcessPendingMessages() {
On 2017/05/04 02:58:55, sky wrote:
> How about removing this function entirely and having callers use
> base::RunLoop().RunUntilIdle() directly?

Done in a separate CL https://codereview.chromium.org/2870633002/

[sky, 2017-05-08 16:12:22]

LGTM

[fdoray, 2017-05-08 16:14:57]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2017-05-08 16:15:02]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-05-08 16:15:03]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2852373004/#ps80001
(title: "Reset-RenderViewTest")

[commit-bot: I haz the power, 2017-05-08 16:15:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 16:27:02]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494260102385370,
"parent_rev": "fac798ecc52156a56b4c9bb337def9ccf652592b", "commit_rev":
"09a43efb68e4412a8e091272df60eef6f50ac355"}

[commit-bot: I haz the power, 2017-05-08 16:27:10]

Description was changed from

==========
Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8.

This is a prerequisite to migrate v8 from base::WorkerPool to
base::TaskScheduler.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
==========

to

==========
Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8.

This is a prerequisite to migrate v8 from base::WorkerPool to
base::TaskScheduler.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584

Review-Url: https://codereview.chromium.org/2852373004
Cr-Commit-Position: refs/heads/master@{#470007}
Committed:
https://chromium.googlesource.com/chromium/src/+/09a43efb68e4412a8e091272df60...
==========

[commit-bot: I haz the power, 2017-05-08 16:27:11]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/09a43efb68e4412a8e091272df60...