Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: extensions/renderer/api_binding_test.h

Issue 2852373004: Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8. (Closed)
Patch Set: Reset-RenderViewTest Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/ppapi_unittest.cc ('k') | extensions/renderer/gc_callback_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_binding_test.h
diff --git a/extensions/renderer/api_binding_test.h b/extensions/renderer/api_binding_test.h
index 41e2b050360dcb48f69cf4d4365508fd01432a6a..76e0f71626bba3a383c38f358a2311099481e05d 100644
--- a/extensions/renderer/api_binding_test.h
+++ b/extensions/renderer/api_binding_test.h
@@ -9,7 +9,7 @@
#include <vector>
#include "base/macros.h"
-#include "base/message_loop/message_loop.h"
+#include "base/test/scoped_task_environment.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "v8/include/v8.h"
@@ -58,7 +58,8 @@ class APIBindingTest : public testing::Test {
private:
void RunGarbageCollection();
- base::MessageLoop message_loop_;
+ base::test::ScopedTaskEnvironment scoped_task_environment_;
+
std::unique_ptr<gin::IsolateHolder> isolate_holder_;
std::unique_ptr<gin::ContextHolder> main_context_holder_;
std::vector<std::unique_ptr<gin::ContextHolder>> additional_context_holders_;
« no previous file with comments | « content/test/ppapi_unittest.cc ('k') | extensions/renderer/gc_callback_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698