Use ScopedTaskEnvironment instead of MessageLoop in RenderViewTest.

Use ScopedTaskEnvironment instead of MessageLoop in RenderViewTest.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

This CL also removes RenderViewTest::ProcessPendingMessages().

BUG=708584
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2870633002
Cr-Commit-Position: refs/heads/master@{#470047}
Committed: https://chromium.googlesource.com/chromium/src/+/752948ba8f63184d42f7188a82d5580686e428f6

[fdoray, 2017-05-08 15:17:30]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 15:17:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-05-08 15:19:10]

Description was changed from

==========
Use ScopedTaskEnvironment instead of MessageLoop in RenderViewTest.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
==========

to

==========
Use ScopedTaskEnvironment instead of MessageLoop in RenderViewTest.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

This CL also removes RenderViewTest::ProcessPendingMessages().

BUG=708584
==========

[fdoray, 2017-05-08 15:19:37]

fdoray@chromium.org changed reviewers:
+ sky@chromium.org

[fdoray, 2017-05-08 15:19:37]

PTAL

This is a change that you requested in
https://codereview.chromium.org/2852373004/

[commit-bot: I haz the power, 2017-05-08 15:28:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 15:28:22]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[sky, 2017-05-08 16:12:07]

Thanks, LGTM

[fdoray, 2017-05-08 16:42:45]

Description was changed from

==========
Use ScopedTaskEnvironment instead of MessageLoop in RenderViewTest.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

This CL also removes RenderViewTest::ProcessPendingMessages().

BUG=708584
==========

to

==========
Use ScopedTaskEnvironment instead of MessageLoop in RenderViewTest.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

This CL also removes RenderViewTest::ProcessPendingMessages().

BUG=708584
TBR=jam@chromium.org
==========

[fdoray, 2017-05-08 16:42:45]

fdoray@chromium.org changed reviewers:
+ jam@chromium.org

[fdoray, 2017-05-08 16:42:55]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2017-05-08 16:43:08]

TBR jam@ for trivial content/renderer/ and components/ changes

[fdoray, 2017-05-08 16:43:10]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2017-05-08 16:43:13]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-05-08 16:43:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2870633002/#ps20001
(title: "fix-build-error")

[commit-bot: I haz the power, 2017-05-08 16:44:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 16:58:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 16:58:42]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[fdoray, 2017-05-08 17:09:54]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-05-08 17:10:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 18:01:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494263394458290,
"parent_rev": "c4a9fa7f810710c0872eb72826916bf9c060063a", "commit_rev":
"752948ba8f63184d42f7188a82d5580686e428f6"}

[commit-bot: I haz the power, 2017-05-08 18:04:36]

Description was changed from

==========
Use ScopedTaskEnvironment instead of MessageLoop in RenderViewTest.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

This CL also removes RenderViewTest::ProcessPendingMessages().

BUG=708584
TBR=jam@chromium.org
==========

to

==========
Use ScopedTaskEnvironment instead of MessageLoop in RenderViewTest.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

This CL also removes RenderViewTest::ProcessPendingMessages().

BUG=708584
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2870633002
Cr-Commit-Position: refs/heads/master@{#470047}
Committed:
https://chromium.googlesource.com/chromium/src/+/752948ba8f63184d42f7188a82d5...
==========

[commit-bot: I haz the power, 2017-05-08 18:04:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/752948ba8f63184d42f7188a82d5...