Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: gin/test/file_runner.cc

Issue 2852373004: Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8. (Closed)
Patch Set: Reset-RenderViewTest Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/shell_runner_unittest.cc ('k') | gin/test/v8_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/test/file_runner.cc
diff --git a/gin/test/file_runner.cc b/gin/test/file_runner.cc
index c8e9f530d9888e18c7c93dfd827229832aa5bbc1..a9c77fba6f1fce0641473a4cfd1fb3618b177104 100644
--- a/gin/test/file_runner.cc
+++ b/gin/test/file_runner.cc
@@ -5,9 +5,9 @@
#include "gin/test/file_runner.h"
#include "base/files/file_util.h"
-#include "base/message_loop/message_loop.h"
#include "base/path_service.h"
#include "base/run_loop.h"
+#include "base/test/scoped_task_environment.h"
#include "base/threading/thread_task_runner_handle.h"
#include "gin/array_buffer.h"
#include "gin/converter.h"
@@ -59,7 +59,7 @@ void RunTestFromFile(const base::FilePath& path, FileRunnerDelegate* delegate,
std::string source;
ASSERT_TRUE(ReadFileToString(path, &source));
- base::MessageLoop message_loop;
+ base::test::ScopedTaskEnvironment scoped_task_environment;
#ifdef V8_USE_EXTERNAL_STARTUP_DATA
gin::V8Initializer::LoadV8Snapshot();
« no previous file with comments | « gin/shell_runner_unittest.cc ('k') | gin/test/v8_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698