Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gin/shell_runner_unittest.cc

Issue 2852373004: Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8. (Closed)
Patch Set: Reset-RenderViewTest Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/modules/timer_unittest.cc ('k') | gin/test/file_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/shell_runner_unittest.cc
diff --git a/gin/shell_runner_unittest.cc b/gin/shell_runner_unittest.cc
index 0743ededb62ed7f9bb77b202cf6765da314a62a7..02e6835abcfaea8172c07f2cda9e71ebdcd1ee5e 100644
--- a/gin/shell_runner_unittest.cc
+++ b/gin/shell_runner_unittest.cc
@@ -5,7 +5,7 @@
#include "gin/shell_runner.h"
#include "base/compiler_specific.h"
-#include "base/message_loop/message_loop.h"
+#include "base/test/scoped_task_environment.h"
#include "base/threading/thread_task_runner_handle.h"
#include "gin/array_buffer.h"
#include "gin/converter.h"
@@ -25,7 +25,7 @@ using v8::String;
namespace gin {
TEST(RunnerTest, Run) {
- base::MessageLoop message_loop;
+ base::test::ScopedTaskEnvironment scoped_task_environment;
std::string source = "this.result = 'PASS';\n";
#ifdef V8_USE_EXTERNAL_STARTUP_DATA
« no previous file with comments | « gin/modules/timer_unittest.cc ('k') | gin/test/file_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698