Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: gin/test/v8_test.h

Issue 2852373004: Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8. (Closed)
Patch Set: Reset-RenderViewTest Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gin/test/file_runner.cc ('k') | mojo/edk/js/tests/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_TEST_V8_TEST_H_ 5 #ifndef GIN_TEST_V8_TEST_H_
6 #define GIN_TEST_V8_TEST_H_ 6 #define GIN_TEST_V8_TEST_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/message_loop/message_loop.h" 12 #include "base/test/scoped_task_environment.h"
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 #include "v8/include/v8.h" 14 #include "v8/include/v8.h"
15 15
16 namespace gin { 16 namespace gin {
17 17
18 class IsolateHolder; 18 class IsolateHolder;
19 19
20 // V8Test is a simple harness for testing interactions with V8. V8Test doesn't 20 // V8Test is a simple harness for testing interactions with V8. V8Test doesn't
21 // have any dependencies on Gin's module system. 21 // have any dependencies on Gin's module system.
22 class V8Test : public testing::Test { 22 class V8Test : public testing::Test {
23 public: 23 public:
24 V8Test(); 24 V8Test();
25 ~V8Test() override; 25 ~V8Test() override;
26 26
27 void SetUp() override; 27 void SetUp() override;
28 void TearDown() override; 28 void TearDown() override;
29 29
30 protected: 30 protected:
31 base::MessageLoop message_loop_; 31 base::test::ScopedTaskEnvironment scoped_task_environment_;
32 std::unique_ptr<IsolateHolder> instance_; 32 std::unique_ptr<IsolateHolder> instance_;
33 v8::Persistent<v8::Context> context_; 33 v8::Persistent<v8::Context> context_;
34 34
35 private: 35 private:
36 DISALLOW_COPY_AND_ASSIGN(V8Test); 36 DISALLOW_COPY_AND_ASSIGN(V8Test);
37 }; 37 };
38 38
39 } // namespace gin 39 } // namespace gin
40 40
41 #endif // GIN_TEST_V8_TEST_H_ 41 #endif // GIN_TEST_V8_TEST_H_
OLDNEW
« no previous file with comments | « gin/test/file_runner.cc ('k') | mojo/edk/js/tests/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698