Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Unified Diff: content/test/ppapi_unittest.cc

Issue 2852373004: Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8. (Closed)
Patch Set: Reset-RenderViewTest Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/ppapi_unittest.h ('k') | extensions/renderer/api_binding_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/ppapi_unittest.cc
diff --git a/content/test/ppapi_unittest.cc b/content/test/ppapi_unittest.cc
index 8ebebe0eeceb31c31890ada3ead401a300de9870..2d29083f455781f306f2dc1a061b977916c43cf7 100644
--- a/content/test/ppapi_unittest.cc
+++ b/content/test/ppapi_unittest.cc
@@ -6,7 +6,6 @@
#include <stdint.h>
-#include "base/message_loop/message_loop.h"
#include "content/renderer/pepper/gfx_conversion.h"
#include "content/renderer/pepper/host_globals.h"
#include "content/renderer/pepper/pepper_plugin_instance_impl.h"
@@ -78,8 +77,6 @@ PpapiUnittest::~PpapiUnittest() {
}
void PpapiUnittest::SetUp() {
- message_loop_.reset(new base::MessageLoop());
-
// Initialize the mock module.
ppapi::PpapiPermissions perms;
module_ = new PluginModule("Mock plugin", "1.0", base::FilePath(),
@@ -101,7 +98,6 @@ void PpapiUnittest::SetUp() {
void PpapiUnittest::TearDown() {
instance_ = NULL;
module_ = NULL;
- message_loop_.reset();
PluginModule::ResetHostGlobalsForTest();
}
« no previous file with comments | « content/test/ppapi_unittest.h ('k') | extensions/renderer/api_binding_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698