Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2849243002: Get rid of all pid references from base::SharedMemoryHandle. (Closed)

Created:
3 years, 7 months ago by erikchen
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, gavinp+memory_chromium.org, jam, mac-reviews_chromium.org, pennymac+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of all pid references from base::SharedMemoryHandle. base::SharedMemory used to support synchronous transport of handles into other processes using base::SharedMemory::ShareToProcess. This required base::SharedMemoryHandle to also track whether the OS resource belonged to the current process. ShareToProcess has been removed, so all the pid tracking is no longer necessary. BUG=716206 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng TBR=wfh@chromium.org Review-Url: https://codereview.chromium.org/2849243002 Cr-Commit-Position: refs/heads/master@{#469012} Committed: https://chromium.googlesource.com/chromium/src/+/996f592abbeaa1b6a14d0fa4073e709cf57b5207

Patch Set 1 #

Patch Set 2 : more remove pid. #

Patch Set 3 : more procid fixes. #

Patch Set 4 : Compile errors, rebase. #

Patch Set 5 : Compile errors + rebase. #

Patch Set 6 : Compile errors + rebase. #

Patch Set 7 : more compile fixes. #

Patch Set 8 : more compile fixes. #

Patch Set 9 : Rebase. #

Patch Set 10 : Deserialization error. #

Patch Set 11 : fix invalid handle Chrome IPC. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -116 lines) Patch
M base/memory/shared_memory_handle.h View 1 2 3 4 4 chunks +3 lines, -21 lines 0 comments Download
M base/memory/shared_memory_handle_mac.cc View 1 4 chunks +2 lines, -7 lines 0 comments Download
M base/memory/shared_memory_handle_win.cc View 1 2 3 4 4 chunks +4 lines, -20 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M base/memory/shared_memory_mac_unittest.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/memory/shared_memory_win.cc View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M base/metrics/field_trial.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_utils.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +22 lines, -34 lines 0 comments Download
M mojo/edk/embedder/platform_shared_buffer.cc View 1 2 3 4 5 6 2 chunks +4 lines, -8 lines 0 comments Download
M mojo/edk/system/platform_wrapper_unittest.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/public/cpp/system/platform_handle.cc View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M sandbox/win/src/process_mitigations_win32k_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/tests/common/controller.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/mojo/buffer_types_struct_traits.cc View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 55 (44 generated)
erikchen
thakis: Please review. rockot: Please review ipc/.
3 years, 7 months ago (2017-05-02 14:27:19 UTC) #15
erikchen
On 2017/05/02 14:27:19, erikchen wrote: > thakis: Please review. > rockot: Please review ipc/. rockot: ...
3 years, 7 months ago (2017-05-02 19:20:10 UTC) #22
Nico
non-mojo files lgtm
3 years, 7 months ago (2017-05-02 20:35:40 UTC) #27
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-05-02 21:33:18 UTC) #28
erikchen
TBR wfh for sandbox/win
3 years, 7 months ago (2017-05-03 13:25:55 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849243002/180001
3 years, 7 months ago (2017-05-03 13:26:19 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849243002/200001
3 years, 7 months ago (2017-05-03 14:41:38 UTC) #47
Will Harris
lgtm
3 years, 7 months ago (2017-05-03 15:51:08 UTC) #48
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/375566)
3 years, 7 months ago (2017-05-03 16:04:05 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849243002/200001
3 years, 7 months ago (2017-05-03 16:28:02 UTC) #52
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 17:12:46 UTC) #55
Message was sent while issue was closed.
Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/996f592abbeaa1b6a14d0fa4073e...

Powered by Google App Engine
This is Rietveld 408576698