Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: mojo/public/cpp/system/platform_handle.cc

Issue 2849243002: Get rid of all pid references from base::SharedMemoryHandle. (Closed)
Patch Set: fix invalid handle Chrome IPC. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/system/platform_handle.cc
diff --git a/mojo/public/cpp/system/platform_handle.cc b/mojo/public/cpp/system/platform_handle.cc
index 63c8c1406ec54d26ffe2d04d20b386df0a4edf6b..7cedb3ac85684fe4fdbd24d5dfa885131688bf4d 100644
--- a/mojo/public/cpp/system/platform_handle.cc
+++ b/mojo/public/cpp/system/platform_handle.cc
@@ -117,17 +117,15 @@ MojoResult UnwrapSharedMemoryHandle(ScopedSharedBufferHandle handle,
#if defined(OS_MACOSX) && !defined(OS_IOS)
CHECK_EQ(platform_handle.type, MOJO_PLATFORM_HANDLE_TYPE_MACH_PORT);
*memory_handle = base::SharedMemoryHandle(
- static_cast<mach_port_t>(platform_handle.value), num_bytes,
- base::GetCurrentProcId());
+ static_cast<mach_port_t>(platform_handle.value), num_bytes);
#elif defined(OS_POSIX)
CHECK_EQ(platform_handle.type, MOJO_PLATFORM_HANDLE_TYPE_FILE_DESCRIPTOR);
*memory_handle = base::SharedMemoryHandle(
base::FileDescriptor(static_cast<int>(platform_handle.value), false));
#elif defined(OS_WIN)
CHECK_EQ(platform_handle.type, MOJO_PLATFORM_HANDLE_TYPE_WINDOWS_HANDLE);
- *memory_handle = base::SharedMemoryHandle(
- reinterpret_cast<HANDLE>(platform_handle.value),
- base::GetCurrentProcId());
+ *memory_handle =
+ base::SharedMemoryHandle(reinterpret_cast<HANDLE>(platform_handle.value));
#endif
return MOJO_RESULT_OK;
« no previous file with comments | « mojo/edk/system/platform_wrapper_unittest.cc ('k') | sandbox/win/src/process_mitigations_win32k_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698