Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1957)

Unified Diff: base/memory/shared_memory_handle.h

Issue 2849243002: Get rid of all pid references from base::SharedMemoryHandle. (Closed)
Patch Set: fix invalid handle Chrome IPC. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/memory/shared_memory_handle_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/shared_memory_handle.h
diff --git a/base/memory/shared_memory_handle.h b/base/memory/shared_memory_handle.h
index b293054ee86c5e00029430a50edc61429c82a2b2..d66c3c156180626ac4a9718fd1989b8012fd1b2f 100644
--- a/base/memory/shared_memory_handle.h
+++ b/base/memory/shared_memory_handle.h
@@ -83,10 +83,8 @@ class BASE_EXPORT SharedMemoryHandle {
explicit SharedMemoryHandle(mach_vm_size_t size);
// Makes a Mach-based SharedMemoryHandle from |memory_object|, a named entry
- // in the task with process id |pid|. The memory region has size |size|.
- SharedMemoryHandle(mach_port_t memory_object,
- mach_vm_size_t size,
- base::ProcessId pid);
+ // in the current task. The memory region has size |size|.
+ SharedMemoryHandle(mach_port_t memory_object, mach_vm_size_t size);
// Exposed so that the SharedMemoryHandle can be transported between
// processes.
@@ -102,17 +100,9 @@ class BASE_EXPORT SharedMemoryHandle {
// mapped memory.
bool MapAt(off_t offset, size_t bytes, void** memory, bool read_only);
#elif defined(OS_WIN)
- SharedMemoryHandle(HANDLE h, base::ProcessId pid);
-
- // Whether |pid_| is the same as the current process's id.
- bool BelongsToCurrentProcess() const;
-
- // Whether handle_ needs to be duplicated into the destination process when
- // an instance of this class is passed over a Chrome IPC channel.
- bool NeedsBrokering() const;
+ SharedMemoryHandle(HANDLE h);
HANDLE GetHandle() const;
- base::ProcessId GetPID() const;
#else
// This constructor is deprecated, as it fails to propagate the GUID, which
// will be added in the near future.
@@ -156,10 +146,6 @@ class BASE_EXPORT SharedMemoryHandle {
// relevant if |memory_object_| is not |MACH_PORT_NULL|.
mach_vm_size_t size_;
- // The pid of the process in which |memory_object_| is usable. Only
- // relevant if |memory_object_| is not |MACH_PORT_NULL|.
- base::ProcessId pid_;
-
// Whether passing this object as a parameter to an IPC message passes
// ownership of |memory_object_| to the IPC stack. This is meant to mimic
// the behavior of the |auto_close| parameter of FileDescriptor.
@@ -170,10 +156,6 @@ class BASE_EXPORT SharedMemoryHandle {
#elif defined(OS_WIN)
HANDLE handle_;
- // The process in which |handle_| is valid and can be used. If |handle_| is
- // invalid, this will be kNullProcessId.
- base::ProcessId pid_;
-
// Whether passing this object as a parameter to an IPC message passes
// ownership of |handle_| to the IPC stack. This is meant to mimic the
// behavior of the |auto_close| parameter of FileDescriptor. This member only
« no previous file with comments | « no previous file | base/memory/shared_memory_handle_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698