sandbox/win/tests/common/controller.cc - Issue 2849243002: Get rid of all pid references from base::SharedMemoryHandle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/tests/common/controller.cc

Issue 2849243002: Get rid of all pid references from base::SharedMemoryHandle. (Closed)

Patch Set: fix invalid handle Chrome IPC. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/win/tests/common/controller.cc

diff --git a/sandbox/win/tests/common/controller.cc b/sandbox/win/tests/common/controller.cc

index 0d2973f045afeb464995700be674849963f37fbd..24070e78c1bd7f256998c553cb74f1e9b2713771 100644

--- a/sandbox/win/tests/common/controller.cc

+++ b/sandbox/win/tests/common/controller.cc

@@ -315,8 +315,7 @@ int DispatchCall(int argc, wchar_t **argv) {

base::StringToUint(argv[4], reinterpret_cast<unsigned int*>(&raw_handle));

if (raw_handle == nullptr)

return SBOX_TEST_INVALID_PARAMETER;

- base::SharedMemoryHandle shared_handle(raw_handle,

- base::GetCurrentProcId());

+ base::SharedMemoryHandle shared_handle(raw_handle);

base::SharedMemory read_only_view(shared_handle, true);

if (!read_only_view.Map(0))

return SBOX_TEST_INVALID_PARAMETER;