base/metrics/field_trial.cc - Issue 2849243002: Get rid of all pid references from base::SharedMemoryHandle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/field_trial.cc

Issue 2849243002: Get rid of all pid references from base::SharedMemoryHandle. (Closed)

Patch Set: fix invalid handle Chrome IPC. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/field_trial.cc

diff --git a/base/metrics/field_trial.cc b/base/metrics/field_trial.cc

index af83f63cc3abb6540817e281f9996234a737b418..e6274bb5c91c181784b51f5ad5f706458a420eba 100644

--- a/base/metrics/field_trial.cc

+++ b/base/metrics/field_trial.cc

@@ -1137,7 +1137,7 @@ bool FieldTrialList::CreateTrialsFromHandleSwitch(

const std::string& handle_switch) {

int field_trial_handle = std::stoi(handle_switch);

HANDLE handle = reinterpret_cast<HANDLE>(field_trial_handle);

- SharedMemoryHandle shm_handle(handle, GetCurrentProcId());

+ SharedMemoryHandle shm_handle(handle);

return FieldTrialList::CreateTrialsFromSharedMemoryHandle(shm_handle);

}

#endif

« no previous file with comments | « base/memory/shared_memory_win.cc ('k') | ipc/ipc_message_utils.cc » ('j') | no next file with comments »