Use SharedMemoryHandle instead ScopedHandle as ivar for SharedMemory

Use SharedMemoryHandle instead ScopedHandle as ivar for SharedMemory

Only Windows was using ScopedHandle. Other platforms already used a
SharedMemoryHandle directly. The theoretical benefit of ScopedHandle is that it
correctly deals with ownership. But all that does is ensure that the handle is
closed during destruction of SharedMemory, which is already explicitly coded,
since it's needed on all platforms. Switching to SharedMemoryHandle is needed to
correctly propagate other state on SharedMemoryHandle, which is being added in
the near future.

BUG=713763
Review-Url: https://codereview.chromium.org/2854833004
Cr-Commit-Position: refs/heads/master@{#469179}
Committed: https://chromium.googlesource.com/chromium/src/+/3df1dd51204370d6289ce46252d3c416c272447e

[erikchen, 2017-05-02 14:59:14]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 14:59:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2017-05-02 15:00:40]

Description was changed from

==========
Use SHM instead of scoped handle for Windows.

BUG=
==========

to

==========
Use SharedMemoryHandle instead ScopedHandle as ivar for SharedMemory

BUG=
==========

[commit-bot: I haz the power, 2017-05-02 15:10:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 15:10:27]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2017-05-02 19:14:14]

Description was changed from

==========
Use SharedMemoryHandle instead ScopedHandle as ivar for SharedMemory

BUG=
==========

to

==========
Use SharedMemoryHandle instead ScopedHandle as ivar for SharedMemory

BUG=
==========

[erikchen, 2017-05-02 19:14:19]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 19:14:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2017-05-02 19:18:21]

Description was changed from

==========
Use SharedMemoryHandle instead ScopedHandle as ivar for SharedMemory

BUG=
==========

to

==========
Use SharedMemoryHandle instead ScopedHandle as ivar for SharedMemory

Only Windows was using ScopedHandle. Other platforms already used a
SharedMemoryHandle directly. The theoretical benefit of ScopedHandle is that it
correctly deals with ownership. But all that does is ensure that the handle is
closed during destruction of SharedMemory, which is already explicitly coded,
since it's needed on all platforms. Switching to SharedMemoryHandle is needed to
correctly propagate other state on SharedMemoryHandle, which is being added in
the near future.

BUG=713763
==========

[erikchen, 2017-05-02 19:18:35]

erikchen@chromium.org changed reviewers:
+ thakis@chromium.org

[erikchen, 2017-05-02 19:18:36]

thakis: Please review.

[erikchen, 2017-05-02 19:24:07]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 19:24:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 19:35:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 19:35:39]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Nico, 2017-05-02 20:37:52]

lgtm

https://codereview.chromium.org/2854833004/diff/40001/base/memory/shared_memo...
File base/memory/shared_memory_handle.h (right):

https://codereview.chromium.org/2854833004/diff/40001/base/memory/shared_memo...
base/memory/shared_memory_handle.h:157: friend class SharedMemory;
:-(

[erikchen, 2017-05-03 16:57:58]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 16:58:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2017-05-03 17:19:44]

The CQ bit was unchecked by erikchen@chromium.org

[erikchen, 2017-05-03 17:19:44]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2017-05-03 17:19:44]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2854833004/#ps60001
(title: "Compile fix + Rebase.")

[commit-bot: I haz the power, 2017-05-03 17:19:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 18:20:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 18:20:14]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[erikchen, 2017-05-03 18:40:50]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2017-05-03 18:40:50]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2854833004/#ps100001
(title: "clean up")

[commit-bot: I haz the power, 2017-05-03 18:41:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 19:57:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 19:57:13]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[erikchen, 2017-05-03 21:36:03]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2017-05-03 21:36:03]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2854833004/#ps80002
(title: "close should be idempotent.")

[commit-bot: I haz the power, 2017-05-03 21:36:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 22:53:43]

CQ is committing da patch.

Bot data: {"patchset_id": 80002, "attempt_start_ts": 1493847363594950,
"parent_rev": "02084c771e830293de3cc4919d29a83341558035", "commit_rev":
"3df1dd51204370d6289ce46252d3c416c272447e"}

[commit-bot: I haz the power, 2017-05-03 22:53:57]

Description was changed from

==========
Use SharedMemoryHandle instead ScopedHandle as ivar for SharedMemory

Only Windows was using ScopedHandle. Other platforms already used a
SharedMemoryHandle directly. The theoretical benefit of ScopedHandle is that it
correctly deals with ownership. But all that does is ensure that the handle is
closed during destruction of SharedMemory, which is already explicitly coded,
since it's needed on all platforms. Switching to SharedMemoryHandle is needed to
correctly propagate other state on SharedMemoryHandle, which is being added in
the near future.

BUG=713763
==========

to

==========
Use SharedMemoryHandle instead ScopedHandle as ivar for SharedMemory

Only Windows was using ScopedHandle. Other platforms already used a
SharedMemoryHandle directly. The theoretical benefit of ScopedHandle is that it
correctly deals with ownership. But all that does is ensure that the handle is
closed during destruction of SharedMemory, which is already explicitly coded,
since it's needed on all platforms. Switching to SharedMemoryHandle is needed to
correctly propagate other state on SharedMemoryHandle, which is being added in
the near future.

BUG=713763

Review-Url: https://codereview.chromium.org/2854833004
Cr-Commit-Position: refs/heads/master@{#469179}
Committed:
https://chromium.googlesource.com/chromium/src/+/3df1dd51204370d6289ce46252d3...
==========

[commit-bot: I haz the power, 2017-05-03 22:54:00]

Committed patchset #7 (id:80002) as
https://chromium.googlesource.com/chromium/src/+/3df1dd51204370d6289ce46252d3...