Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: base/memory/shared_memory_mac.cc

Issue 2849243002: Get rid of all pid references from base::SharedMemoryHandle. (Closed)
Patch Set: fix invalid handle Chrome IPC. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/memory/shared_memory_handle_win.cc ('k') | base/memory/shared_memory_mac_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/shared_memory.h" 5 #include "base/memory/shared_memory.h"
6 6
7 #include <errno.h> 7 #include <errno.h>
8 #include <mach/mach_vm.h> 8 #include <mach/mach_vm.h>
9 #include <stddef.h> 9 #include <stddef.h>
10 #include <sys/mman.h> 10 #include <sys/mman.h>
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 67
68 // Make new memory object. 68 // Make new memory object.
69 mach_port_t named_right; 69 mach_port_t named_right;
70 kern_return_t kr = mach_make_memory_entry_64( 70 kern_return_t kr = mach_make_memory_entry_64(
71 mach_task_self(), reinterpret_cast<memory_object_size_t*>(&size), 71 mach_task_self(), reinterpret_cast<memory_object_size_t*>(&size),
72 reinterpret_cast<memory_object_offset_t>(temp_addr), VM_PROT_READ, 72 reinterpret_cast<memory_object_offset_t>(temp_addr), VM_PROT_READ,
73 &named_right, MACH_PORT_NULL); 73 &named_right, MACH_PORT_NULL);
74 if (kr != KERN_SUCCESS) 74 if (kr != KERN_SUCCESS)
75 return false; 75 return false;
76 76
77 *new_handle = SharedMemoryHandle(named_right, size, base::GetCurrentProcId()); 77 *new_handle = SharedMemoryHandle(named_right, size);
78 return true; 78 return true;
79 } 79 }
80 80
81 81
82 } // namespace 82 } // namespace
83 83
84 SharedMemory::SharedMemory() 84 SharedMemory::SharedMemory()
85 : mapped_memory_mechanism_(SharedMemoryHandle::MACH), 85 : mapped_memory_mechanism_(SharedMemoryHandle::MACH),
86 mapped_size_(0), 86 mapped_size_(0),
87 memory_(NULL), 87 memory_(NULL),
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 271
272 DCHECK(shm_.IsValid()); 272 DCHECK(shm_.IsValid());
273 base::SharedMemoryHandle new_handle; 273 base::SharedMemoryHandle new_handle;
274 bool success = MakeMachSharedMemoryHandleReadOnly(&new_handle, shm_, memory_); 274 bool success = MakeMachSharedMemoryHandleReadOnly(&new_handle, shm_, memory_);
275 if (success) 275 if (success)
276 new_handle.SetOwnershipPassesToIPC(true); 276 new_handle.SetOwnershipPassesToIPC(true);
277 return new_handle; 277 return new_handle;
278 } 278 }
279 279
280 } // namespace base 280 } // namespace base
OLDNEW
« no previous file with comments | « base/memory/shared_memory_handle_win.cc ('k') | base/memory/shared_memory_mac_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698