Use unique_ptr for Create{ServiceWorkerNetworkProvider,ApplicationCacheHost}

Use unique_ptr for Create{ServiceWorkerNetworkProvider,ApplicationCacheHost}

BUG=n/a

Review-Url: https://codereview.chromium.org/2847983002
Cr-Commit-Position: refs/heads/master@{#468305}
Committed: https://chromium.googlesource.com/chromium/src/+/c362658d2401554189fb6cb79f8e3c4f028fcbee

[kinuko, 2017-04-28 15:34:31]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 15:34:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 15:51:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 15:51:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kinuko, 2017-04-29 14:13:47]

Patchset #2 (id:20001) has been deleted

[kinuko, 2017-04-29 14:42:21]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 14:42:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 16:30:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 16:30:31]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-04-30 16:28:02]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-30 16:28:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-30 17:52:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-30 17:52:59]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-05-01 04:50:38]

Description was changed from

==========
Use unique_ptr for Create{ServiceWorkerNetworkProvider,ApplicationCacheHost}

BUG=n/a
==========

to

==========
Use unique_ptr for Create{ServiceWorkerNetworkProvider,ApplicationCacheHost}

BUG=n/a
==========

[kinuko, 2017-05-01 04:50:39]

kinuko@chromium.org changed reviewers:
+ nhiroki@chromium.org

[kinuko, 2017-05-01 04:50:49]

PTL

[nhiroki, 2017-05-01 05:04:28]

LGTM with minor comments

https://codereview.chromium.org/2847983002/diff/60001/third_party/WebKit/publ...
File third_party/WebKit/public/web/WebSharedWorkerClient.h (right):

https://codereview.chromium.org/2847983002/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/web/WebSharedWorkerClient.h:83: // Ownership of the
returned object is transferred to the caller.
This ownership comment would be no longer useful.

https://codereview.chromium.org/2847983002/diff/60001/third_party/WebKit/publ...
File
third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
(right):

https://codereview.chromium.org/2847983002/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h:241:
// Ownership of the returned object is transferred to the caller.
ditto.

https://codereview.chromium.org/2847983002/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h:254:
// Ownership of the returned object is transferred to the caller.
ditto.

[kinuko, 2017-05-01 05:21:54]

Thanks! All addressed.

[kinuko, 2017-05-01 05:21:59]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2017-05-01 05:21:59]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2847983002/#ps80001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-05-01 05:22:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 07:27:55]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493616119075060,
"parent_rev": "08b287f8807022c5c6369eafccad38ad3492cd9f", "commit_rev":
"c362658d2401554189fb6cb79f8e3c4f028fcbee"}

[commit-bot: I haz the power, 2017-05-01 07:28:06]

Description was changed from

==========
Use unique_ptr for Create{ServiceWorkerNetworkProvider,ApplicationCacheHost}

BUG=n/a
==========

to

==========
Use unique_ptr for Create{ServiceWorkerNetworkProvider,ApplicationCacheHost}

BUG=n/a

Review-Url: https://codereview.chromium.org/2847983002
Cr-Commit-Position: refs/heads/master@{#468305}
Committed:
https://chromium.googlesource.com/chromium/src/+/c362658d2401554189fb6cb79f8e...
==========

[commit-bot: I haz the power, 2017-05-01 07:28:07]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c362658d2401554189fb6cb79f8e...