Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Unified Diff: third_party/WebKit/public/web/WebSharedWorkerClient.h

Issue 2847983002: Use unique_ptr for Create{ServiceWorkerNetworkProvider,ApplicationCacheHost} (Closed)
Patch Set: addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebSharedWorkerClient.h
diff --git a/third_party/WebKit/public/web/WebSharedWorkerClient.h b/third_party/WebKit/public/web/WebSharedWorkerClient.h
index 93ac90f52e40bf3689566bbf2b9fda00e4566d34..a674292b9dfe592c6bf194d116d87ca4813b1aeb 100644
--- a/third_party/WebKit/public/web/WebSharedWorkerClient.h
+++ b/third_party/WebKit/public/web/WebSharedWorkerClient.h
@@ -67,7 +67,7 @@ class WebSharedWorkerClient {
// Called on the main webkit thread in the worker process during
// initialization.
- virtual WebApplicationCacheHost* CreateApplicationCacheHost(
+ virtual std::unique_ptr<WebApplicationCacheHost> CreateApplicationCacheHost(
WebApplicationCacheHostClient*) = 0;
// Called on the main thread during initialization.
@@ -80,11 +80,8 @@ class WebSharedWorkerClient {
}
// Called on the main thread during initialization.
- // Ownership of the returned object is transferred to the caller.
- virtual WebServiceWorkerNetworkProvider*
- CreateServiceWorkerNetworkProvider() {
- return nullptr;
- }
+ virtual std::unique_ptr<WebServiceWorkerNetworkProvider>
+ CreateServiceWorkerNetworkProvider() = 0;
virtual void SendDevToolsMessage(int session_id,
int call_id,

Powered by Google App Engine
This is Rietveld 408576698