Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

Issue 2847983002: Use unique_ptr for Create{ServiceWorkerNetworkProvider,ApplicationCacheHost} (Closed)
Patch Set: addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
index 72cdbe460e7453d2cda73db474f409bd95d499fd..fbb86ac9a1b69e87461d213e6ea3d873d85f18b4 100644
--- a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
@@ -329,8 +329,8 @@ void WebEmbeddedWorkerImpl::DidFinishDocumentLoad(WebLocalFrame* frame) {
DCHECK(loading_shadow_page_);
DCHECK(!asked_to_terminate_);
loading_shadow_page_ = false;
- frame->DataSource()->SetServiceWorkerNetworkProvider(WTF::WrapUnique(
- worker_context_client_->CreateServiceWorkerNetworkProvider()));
+ frame->DataSource()->SetServiceWorkerNetworkProvider(
+ worker_context_client_->CreateServiceWorkerNetworkProvider());
main_script_loader_ = WorkerScriptLoader::Create();
main_script_loader_->SetRequestContext(
WebURLRequest::kRequestContextServiceWorker);
@@ -419,12 +419,10 @@ void WebEmbeddedWorkerImpl::StartWorkerThread() {
worker_clients,
ServiceWorkerGlobalScopeClientImpl::Create(*worker_context_client_));
ProvideServiceWorkerContainerClientToWorker(
- worker_clients,
- WTF::WrapUnique(worker_context_client_->CreateServiceWorkerProvider()));
+ worker_clients, worker_context_client_->CreateServiceWorkerProvider());
if (RuntimeEnabledFeatures::offMainThreadFetchEnabled()) {
std::unique_ptr<WebWorkerFetchContext> web_worker_fetch_context =
-
worker_context_client_->CreateServiceWorkerFetchContext();
DCHECK(web_worker_fetch_context);
// TODO(horo): Set more information about the context (ex: DataSaverEnabled)
« no previous file with comments | « third_party/WebKit/Source/web/LocalFrameClientImpl.cpp ('k') | third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698